Repository navigation
feat(pr-pipeline): lift a lanes App needs-human once trusted pushes clear its cause #10389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2731084
feat(pr-pipeline): lift a lanes App needs-human once trusted pushes c…
kyle-sexton 8620518
Merge remote-tracking branch 'origin/main' into feat/lanes-lift-stale…
kyle-sexton b86fa72
Merge remote-tracking branch 'origin/main' into feat/lanes-lift-stale…
kyle-sexton 0f0cb29
Merge remote-tracking branch 'origin/main' into sweep-10389
kyle-sexton 97e1231
Merge remote-tracking branch 'origin/main' into sweep-10389
kyle-sexton 97de5c1
fix(pr-pipeline): lift only the owner-approved stops and floor the ne…
kyle-sexton 59c153f
Merge remote-tracking branch 'origin/main' into sweep-10389
kyle-sexton 9bcfb25
Merge remote-tracking branch 'origin/main' into sweep-10389
kyle-sexton cc5dd8b
chore: merge origin/main into feat/lanes-lift-stale-needs-human
kyle-sexton c81dd1b
fix(pr-pipeline): lift only on human pushes and passing checks, never…
kyle-sexton 93c22ae
chore: merge origin/main into feat/lanes-lift-stale-needs-human
kyle-sexton 8ed9cbc
Merge remote-tracking branch 'origin/main' into sweep-10389
kyle-sexton 0afa6ed
docs(pr-pipeline): say only human pushes make a trusted move in clear…
kyle-sexton 1069436
Merge remote-tracking branch 'origin/main' into sweep-10389
kyle-sexton 6df14e7
Merge remote-tracking branch 'origin/main' into sweep-10389
kyle-sexton b70cc23
Merge remote-tracking branch 'origin/main' into sweep-10389
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| bump: minor | ||
| --- | ||
|
|
||
| ### Added | ||
|
|
||
| - `clear-escalations.mjs` lifts more pr-unblock stops once their cause is gone: `workflow-staged` also clears once a trusted move took the head off the resume key and the head contains main as it was at the escalation; the `ci-fix-*` stops other than `ci-fix-protected-path` clear once a trusted move took the head off the resume key and, at the new head, no check but `ci-status` fails, runs or was cancelled and each check's latest run ended `success`, `neutral` or `skipped`. A trusted move is read with the job token from the branch's activity, never from comment text: every push since the label is by a `human` of the base `trusted-actors.json`, matched by id, never the lanes App. Security, intent, decision, protected-path and own-patch stops still wait for a person. |
7 changes: 7 additions & 0 deletions
7
.changes/source-control/feat-lift-stale-needs-human-floor-3b7d9c51.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| bump: patch | ||
| --- | ||
|
|
||
| ### Changed | ||
|
|
||
| - The merge gate's path floor (`babysit_risk.FLOOR_CLASSES`) holds `.github/scripts/pr-unblock/fix-ci-context.mjs` and `.github/scripts/maintenance-reconcile-lost-runs/infra-failure.mjs` as `enforcement` paths, since `clear-escalations.mjs` now loads them: a change to either waits for a clean security review bound to the head. |
Large diffs are not rendered by default.
Oops, something went wrong.
|
kyle-sexton marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kyle-sexton marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kyle-sexton marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.