Skip to content

fix(planning): separate round.sh and watch.sh exit codes for refusal, missing prerequisite and server start failure #9795

Open

Description

@kyle-sexton

Parent: #7303 (DX-3; the lane limit on interview SKILL.md edits is removed). Blocked by the #7052 planning slice, because the interview SKILL.md and its digests are edited there too.

Problem

plugins/planning/surface/round.sh and watch.sh exit 1 for a refusal, a missing prerequisite, a server start failure and a --diff finding changes; missing curl is 1 from ensure-running and 2 from watch.sh. The interview SKILL.md and context/surface.md state these codes.

Done when

  • Each case has its own documented exit code, and missing curl exits the same code from every entry point.
  • round.sh --help lists the codes.
  • plugins/planning/skills/interview/SKILL.md and context/surface.md state the new codes: git grep -n 'exit' -- plugins/planning/skills/interview/context/surface.md shows them.
  • The surface test suite under plugins/planning/surface/ passes with a case per code.
  • scripts/run-test-file.sh plugins/planning/tests/interview-defenses.test.sh passes (re-pin if a pinned region changed).
  • scripts/check-changelog-fragments.sh passes.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 24, 2026
  2. github-actions commented on Oct 24, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Medium
    Complexity: Medium
    Uncertainty: Known
    Flags: none

    Understood: round.sh and watch.sh in the planning surface currently share exit code 1 for a refusal, a missing prerequisite, a server start failure and a --diff finding changes. Missing curl is also inconsistent (1 from ensure-running, 2 from watch.sh). The request is to give each case its own documented code, make missing curl uniform across entry points, list the codes in round.sh --help, update the interview SKILL.md and surface.md, and add a test per code. The done-when items are concrete. The issue notes it is blocked by the #7052 planning slice. No duplicates spotted.

    Automated triage, applied by the lanes App.

  3. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 24, 2026
  4. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    on Oct 24, 2026
  5. melodic-automation-lanes commented on Oct 24, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane yet: blocker #9790 is not closed as completed by a listed human or a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal value, no hard deadline; normal backlog flow.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions