Skip to content

docs(testing): reword diagnose's purpose sentences #9787

Open

Description

@kyle-sexton

Parent: #7052 (owner decision 2026-10-13: one PR per plugin).

Problem

A copy check during #7009 flagged text in this plugin that shares word runs or one-to-one structure with an upstream source. The repository's rule is our own words, with credit only on docs/upstream/ pages. Line numbers from the filing are stale; locate the passage by the finding.

Local file Upstream (repo@sha, path) Finding
plugins/testing/skills/diagnose/SKILL.md mattpocock/skills@24fe0ef skills/engineering/diagnosing-bugs/SKILL.md same sentence order, shared runs

Fix

Confirm each finding with fingerprint.mjs compare first. If it does not fire, record that in the PR and change nothing. If it fires, rewrite the passage in a new structure with this repository's own examples, keeping every directive and eval expectation. Make sure the upstream source has a credit row on docs/upstream/mattpocock-skills.md.

Done when

  • gh api -H 'Accept: application/vnd.github.raw' 'repos/mattpocock/skills/contents/skills/engineering/diagnosing-bugs/SKILL.md?ref=24fe0ef' > /tmp/upstream-testing-0.md then node plugins/attribution/skills/audit/scripts/fingerprint.mjs compare --local plugins/testing/skills/diagnose/SKILL.md --source /tmp/upstream-testing-0.md | jq .separation.fired prints false.
  • The PR body lists each passage with its before and after longest_span_words and containment.
  • scripts/check-changelog-fragments.sh passes.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 24, 2026
  2. github-actions commented on Oct 24, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Small
    Complexity: Low
    Uncertainty: Known
    Flags: none

    Understood: this asks for a rewrite of the overlapping passages in the testing plugin's diagnose skill, so the copy check against the upstream source no longer fires. The rewrite keeps every directive and eval expectation. It also asks you to confirm the upstream credit row exists. The fingerprint comparison runs first, and nothing changes if it doesn't fire. The done-when items are concrete. I found no missing information and no likely duplicates.

    Automated triage, applied by the lanes App.

  3. added
    priority: lowNice-to-have, cosmetic, or speculative; opportunistic.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 24, 2026
  4. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Oct 24, 2026
  5. melodic-automation-lanes commented on Oct 24, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue lane stopped partway through this issue and needs a person.

    Why, in the run's own words:

    The issue requires confirming the copy finding with fingerprint.mjs compare against the upstream file (mattpocock/skills24fe0ef, skills/engineering/diagnosing-bugs/SKILL.md) before any rewrite. This run cannot fetch that file: the web allowlist excludes github.com and raw.githubusercontent.com, no copy exists in the checkout, and Bash runs only the named wrappers, so neither gh api nor node fingerprint.mjs can run. A rewrite without the before and after longest_span_words and containment numbers would be a guess and could not meet the done-when criteria.

    What the run says it did not do:

    • fingerprint.mjs compare of plugins/testing/skills/diagnose/SKILL.md against the upstream diagnosing-bugs SKILL.md: the upstream file could not be fetched and node cannot be run here
    • Rewrite of the diagnose purpose sentences and before/after longest_span_words and containment numbers
    • Check that docs/upstream/mattpocock-skills.md has a credit row for the diagnosing-bugs source (the file mentions diagnosing-bugs, but the row was not verified)

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40113264046

    To retry, remove needs-human and add agent-ready again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.priority: lowNice-to-have, cosmetic, or speculative; opportunistic.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    No fields configured for Task.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions