Skip to content

docs(code-tidying): reword dissolve-comments' keep list #9786

Closed as not planned
Closed as not planned

Description

@kyle-sexton

Parent: #7052 (owner decision 2026-10-13: one PR per plugin).

Problem

A copy check during #7009 flagged text in this plugin that shares word runs or one-to-one structure with an upstream source. The repository's rule is our own words, with credit only on docs/upstream/ pages. Line numbers from the filing are stale; locate the passage by the finding.

Local file Upstream (repo@sha, path) Finding
plugins/code-tidying/skills/dissolve-comments/reference/triage.md cursor/plugins@12d587dfb2 pstack/agents/comment-sicko.md keep-list in nearly the same wording and order

Fix

Confirm each finding with fingerprint.mjs compare first. If it does not fire, record that in the PR and change nothing. If it fires, rewrite the passage in a new structure with this repository's own examples, keeping every directive and eval expectation. Make sure the upstream source has a credit row on docs/upstream/cursor-pstack.md.

Done when

  • gh api -H 'Accept: application/vnd.github.raw' 'repos/cursor/plugins/contents/pstack/agents/comment-sicko.md?ref=12d587dfb2' > /tmp/upstream-code-tidying-0.md then node plugins/attribution/skills/audit/scripts/fingerprint.mjs compare --local plugins/code-tidying/skills/dissolve-comments/reference/triage.md --source /tmp/upstream-code-tidying-0.md | jq .separation.fired prints false.
  • The PR body lists each passage with its before and after longest_span_words and containment.
  • scripts/check-changelog-fragments.sh passes.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 24, 2026
  2. github-actions commented on Oct 24, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Small
    Complexity: Low
    Uncertainty: Known
    Flags: none

    Understood: a copy check flagged the keep list in the code-tidying plugin's dissolve-comments triage reference as too close to an upstream source. The fix is to confirm the finding with the fingerprint tool. If it fires, reword the passage in this repository's own words and keep every directive and eval expectation. Also confirm the upstream credit row exists. Nothing appears to be missing. No likely duplicates found among the open issues.

    Automated triage, applied by the lanes App.

  3. added
    priority: lowNice-to-have, cosmetic, or speculative; opportunistic.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 24, 2026
  4. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    admission-deferredReady for the issue lane; work-unblock admits it when queued work is under the queued cap
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    admission-deferredReady for the issue lane; work-unblock admits it when queued work is under the queued cap
    on Oct 24, 2026
  5. melodic-automation-lanes commented on Oct 24, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue lane stopped on its usage limit, not on this issue. It keeps agent-ready, and work-unblock starts it again after 2026-10-25T16:00:00Z.

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40140186674

  6. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Oct 25, 2026
  7. added
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Oct 25, 2026
  8. melodic-automation-lanes commented on Oct 25, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue lane stopped partway through this issue and needs a person.

    Why, in the run's own words:

    The issue's first step is to confirm the finding with fingerprint.mjs compare against cursor/plugins12d587dfb2 pstack/agents/comment-sicko.md, and to change nothing if it does not fire. This lane cannot do that: it cannot fetch the upstream file (github.com and raw.githubusercontent.com are not allowed web hosts here, and gh cannot run), and it cannot run node, so fingerprint.mjs cannot run either. Without the upstream text this run cannot tell whether the finding fires, which passage of triage.md matches, or what the before and after longest_span_words and containment values the PR body needs are. Rewriting without that check could change a passage the issue says to leave alone, so nothing was edited. Rerun this in a lane that can fetch from GitHub and run node, or run the comparison by hand and attach its output to the issue.

    What the run says it did not do:

    • fingerprint.mjs compare of triage.md against cursor/plugins12d587dfb2 pstack/agents/comment-sicko.md (the issue's first Done-when item): did not run, because this lane cannot fetch the upstream file or run node.
    • The rewrite of the keep-list passage, and the PR-body table of before and after longest_span_words and containment: not done, because both depend on the comparison above.
    • Review, build and test steps: skipped, because there is no diff.

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40181681558

    To retry, remove needs-human and add agent-ready again.

  9. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    on Oct 25, 2026
  10. melodic-automation-lanes commented on Oct 25, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue run that agent-ready started failed or was cancelled before it reported, or it stopped or the token broker refused it because its workflow files differ from main's. work-unblock removed and added agent-ready back to start a fresh run on main's workflow files. If this run ends the same way, it re-fires the issue again, waiting longer each time.

  11. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Oct 25, 2026
  12. melodic-automation-lanes commented on Oct 25, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue lane stopped partway through this issue and needs a person.

    Why, in the run's own words:

    The issue makes every edit depend on node plugins/attribution/skills/audit/scripts/fingerprint.mjs compare against the upstream file fetched raw with gh api. The fix rule is 'if it does not fire, record that and change nothing; if it fires, rewrite'. This lane can't run node or gh, so neither the gating compare nor the Done-when check can run here. WebFetch returns a model summary of the upstream page, not its exact bytes, so the shingle comparison can't be reproduced by hand to tool accuracy either. Nothing was changed. A lane that can run node and gh should run the compare. The findings below suggest it will not fire on triage.md, in which case the issue closes with no change.

    What the run says it did not do:

    • The issue's gating and Done-when check: gh api raw fetch of cursor/plugins12d587dfb2 pstack/agents/comment-sicko.md, then node plugins/attribution/skills/audit/scripts/fingerprint.mjs compare --local plugins/code-tidying/skills/dissolve-comments/reference/triage.md --source <fetched>. Not
    • The PR body's before and after longest_span_words and containment per passage: there are no tool figures to report because the compare could not run
    • Review, build/test and lint steps: skipped because nothing was changed

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40213739706

    To retry, remove needs-human and add agent-ready again.

  13. kyle-sexton commented on Oct 25, 2026

    @kyle-sexton
    MemberAuthor

    Closing as not planned: the copy check this issue's Fix starts with does not fire, and its rule for that case is "record that ... and change nothing".

    Evidence, run 2026-10-25 against main at 5e70951: fingerprint.mjs compare --local plugins/code-tidying/skills/dissolve-comments/reference/triage.md --source <cursor/plugins@12d587dfb2:pstack/agents/comment-sicko.md, fetched raw> returned {"fired":false,"rule":"containment>=0.3||span>=15","longest_span_words":0,"containment":0,"jaccard":0}.

    The upstream source already has a credit row in docs/upstream/cursor-pstack.md, so the Fix's other condition holds too.

    The issue lane could not do this itself: its run stopped because it cannot run node or gh (lane outcome on #9786, run 40213739706).

    Reopen it if a later check finds a structural copy the word-run compare does not measure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.priority: lowNice-to-have, cosmetic, or speculative; opportunistic.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    No fields configured for Task.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions