Repository navigation
docs(architecture): reword improve's interface-design return parts #9784
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.priority: lowNice-to-have, cosmetic, or speculative; opportunistic.Nice-to-have, cosmetic, or speculative; opportunistic.status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.
Description
Parent: #7052 (owner decision 2026-10-13: one PR per plugin).
Problem
A copy check during #7009 flagged text in this plugin that shares word runs or one-to-one structure with an upstream source. The repository's rule is our own words, with credit only on docs/upstream/ pages. Line numbers from the filing are stale; locate the passage by the finding.
| Local file | Upstream (repo@sha, path) | Finding |
|---|---|---|
plugins/architecture/skills/improve/research/deepening/interface-design.md |
mattpocock/skills@24fe0ef skills/engineering/codebase-design/DESIGN-IT-TWICE.md |
same five return parts in the same order |
Fix
Confirm each finding with fingerprint.mjs compare first. If it does not fire, record that in the PR and change nothing. If it fires, rewrite the passage in a new structure with this repository's own examples, keeping every directive and eval expectation. Make sure the upstream source has a credit row on docs/upstream/mattpocock-skills.md.
Done when
-
gh api -H 'Accept: application/vnd.github.raw' 'repos/mattpocock/skills/contents/skills/engineering/codebase-design/DESIGN-IT-TWICE.md?ref=24fe0ef' > /tmp/upstream-architecture-0.mdthennode plugins/attribution/skills/audit/scripts/fingerprint.mjs compare --local plugins/architecture/skills/improve/research/deepening/interface-design.md --source /tmp/upstream-architecture-0.md | jq .separation.firedprintsfalse. - The PR body lists each passage with its before and after
longest_span_wordsandcontainment. -
scripts/check-changelog-fragments.shpasses.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.priority: lowNice-to-have, cosmetic, or speculative; opportunistic.Nice-to-have, cosmetic, or speculative; opportunistic.status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.
Type
Fields
No fields configured for Task.
Activity
github-actions commentedon Oct 24, 2026
Proposed work class: work-class: scoped
Basis: automated intake triage; the lanes App applied this class.
Size: Small
Complexity: Low
Uncertainty: Known
Flags: none
Understood: the copy check flagged one passage in the architecture plugin's improve skill (
interface-design.md) for sharing the same five return parts, in the same order, with an upstream mattpocock/skills file. The fix is to confirm the finding withfingerprint.mjs compare. If it fires, rewrite the passage in a new structure with this repository's own examples and keep every directive and eval expectation. Then check that the upstream credit row exists ondocs/upstream/mattpocock-skills.md. The scope is clear and I found no duplicates to link.Automated triage, applied by the lanes App.
melodic-automation-lanes commentedon Oct 24, 2026
The work-resolve-issue lane stopped partway through this issue and needs a person.
Why, in the run's own words:
What the run says it did not do:
Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40113266909
To retry, remove
needs-humanand addagent-readyagain.kyle-sexton commentedon Oct 25, 2026
Closing as not planned: the copy check this issue's Fix starts with does not fire, and its rule for that case is "record that ... and change nothing".
Evidence, run 2026-10-25 against main at 5e70951:
fingerprint.mjs compare --local plugins/architecture/skills/improve/research/deepening/interface-design.md --source <mattpocock/skills@24fe0ef:skills/engineering/codebase-design/DESIGN-IT-TWICE.md, fetched raw>returned{"fired":false,"rule":"containment>=0.3||span>=15","longest_span_words":0,"containment":0,"jaccard":0}.The upstream source already has a credit row in
docs/upstream/mattpocock-skills.md, so the Fix's other condition holds too.The issue lane could not do this itself: its run stopped because it cannot run node or gh (lane outcome on #9786, run 40213739706).
Reopen it if a later check finds a structural copy the word-run compare does not measure.