Repository navigation
docs(review): reword quality-gate downstream context and the code-reviewer smell list #9782
Copy link
Copy link
Open
Open
Copy link
Labels
host-runNeeds a host or attended run; the host runner takes it, not a person or the issue lane.Needs a host or attended run; the host runner takes it, not a person or the issue lane.priority: lowNice-to-have, cosmetic, or speculative; opportunistic.Nice-to-have, cosmetic, or speculative; opportunistic.status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.
Description
Parent: #7052 (owner decision 2026-10-13: one PR per plugin).
Problem
A copy check during #7009 flagged text in this plugin that shares word runs or one-to-one structure with an upstream source. The repository's rule is our own words, with credit only on docs/upstream/ pages. Line numbers from the filing are stale; locate the passage by the finding.
| Local file | Upstream (repo@sha, path) | Finding |
|---|---|---|
plugins/review/skills/quality-gate/context/downstream.md |
cursor/plugins@12d587dfb2 pstack/skills/blast-radius/SKILL.md |
7-9 word runs; same risks/cleared field order |
plugins/review/agents/code-reviewer.md |
mattpocock/skills@24fe0ef skills/engineering/code-review/SKILL.md |
the same 12-smell selection in nearly the same order |
Fix
Confirm each finding with fingerprint.mjs compare first. If it does not fire, record that in the PR and change nothing. If it fires, rewrite the passage in a new structure with this repository's own examples, keeping every directive and eval expectation. Make sure the upstream source has a credit row on docs/upstream/cursor-pstack.md and the mattpocock-skills page.
Done when
-
gh api -H 'Accept: application/vnd.github.raw' 'repos/cursor/plugins/contents/pstack/skills/blast-radius/SKILL.md?ref=12d587dfb2' > /tmp/upstream-review-0.mdthennode plugins/attribution/skills/audit/scripts/fingerprint.mjs compare --local plugins/review/skills/quality-gate/context/downstream.md --source /tmp/upstream-review-0.md | jq .separation.firedprintsfalse. -
gh api -H 'Accept: application/vnd.github.raw' 'repos/mattpocock/skills/contents/skills/engineering/code-review/SKILL.md?ref=24fe0ef' > /tmp/upstream-review-1.mdthennode plugins/attribution/skills/audit/scripts/fingerprint.mjs compare --local plugins/review/agents/code-reviewer.md --source /tmp/upstream-review-1.md | jq .separation.firedprintsfalse. - The PR body lists each passage with its before and after
longest_span_wordsandcontainment. -
scripts/check-changelog-fragments.shpasses.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
host-runNeeds a host or attended run; the host runner takes it, not a person or the issue lane.Needs a host or attended run; the host runner takes it, not a person or the issue lane.priority: lowNice-to-have, cosmetic, or speculative; opportunistic.Nice-to-have, cosmetic, or speculative; opportunistic.status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.
Type
Fields
No fields configured for Task.
Activity
github-actions commentedon Oct 24, 2026
Proposed work class: work-class: scoped
Basis: automated intake triage; the lanes App applied this class.
Size: Small
Complexity: Low
Uncertainty: Knowable
Flags: none
Understood: a copy check found that two files in the review plugin (the quality-gate downstream context and the code-reviewer agent) overlap with upstream text. The task is to confirm each finding with the fingerprint compare, then reword each passage in its own structure and examples if it fires. It also asks for credit rows on the upstream pages and the before/after metrics in the PR body. The scope is clear and nothing is missing. Fetching the upstream sources may need network access that the issue lane lacks. I found no likely duplicates beyond the parent #7052.
Automated triage, applied by the lanes App.
melodic-automation-lanes commentedon Oct 24, 2026
The work-resolve-issue lane stopped partway through this issue and needs a person.
Why, in the run's own words:
What the run says it did not do:
Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40113254133
To retry, remove
needs-humanand addagent-readyagain.