fix(pr-merge): take a cost decision's decided head from the review lane's check-run annotation, not a bot comment #9635

Activity

1. github-actions

   added

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 24, 2026
2. github-actions commented on Oct 24, 2026

   

   github-actionsBot

   on Oct 24, 2026 – with GitHub Actions

   Last edited by melodic-automation-lanes

   Contributor

   More actions

   Proposed work class: work-class: scoped
   Basis: automated intake triage; the lanes App applied this class.

   Size: Medium
   Complexity: Medium
   Uncertainty: Known
   Flags: none
   Blocked by: none

   Understood: the cost-decision readers (babysit_merge_policy.cost_decision, merge-holds.mjs costDecision, the ci-status lift, and ci-workflows hold.cjs carryDecision) should take the decided head from the review lane's check-run annotation instead of the sha= in a github-actions[bot] marker comment, so the carry doesn't rest on a comment author login. The issue frames this as hardening that widens nothing today. Nothing is missing; the approach is stated. No likely duplicates found among open issues.

   _{Automated triage, applied by the lanes App.}
3. github-actions

   added

   needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.

   on Oct 24, 2026
4. github-actions

   added the

   Bug

   issue type on Oct 24, 2026
5. github-actions

   removed

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 24, 2026
6. melodic-automation-lanes

   added

   status: needs-decisionAwaiting a human or maintainer judgment call.Awaiting a human or maintainer judgment call.

   on Oct 24, 2026
7. kyle-sexton commented on Oct 26, 2026

   

   kyle-sexton

   on Oct 26, 2026

   MemberAuthor

   More actions

   Builder: the Automation Lanes session builds this from the owner's machine. The fix edits .github/workflows, which the lanes App cannot push (patch-rules.json:3); that boundary stays. Its PR closes this issue. needs-human came off under the owner's 2026-10-26 rule (a person only for an intent or vision change, an implementation finding that alters intent or the primary design, or a HIGH/CRITICAL security issue); none applies. agent-ready stays off so the issue lane does not race the build.
8. kyle-sexton

   added

   status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.

   and removed

   status: needs-decisionAwaiting a human or maintainer judgment call.Awaiting a human or maintainer judgment call.

   needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.

   on Oct 26, 2026
9. kyle-sexton commented on Oct 26, 2026

   

   kyle-sexton

   on Oct 26, 2026

   MemberAuthor

   More actions

   Released for re-triage under the owner's 2026-10-26 rule: a person is involved only for "1. A change in original intent/vision 2. Something comes up during implementation ... that alters intent/vision or the primary design 3. If there is a HIGH/CRITICAL security issue". None applies here, so the hold label came off and intake triage runs again now.

   To hold this issue again, add needs-human (or status: needs-decision) and name which of the three applies.
10. github-actions

    added

    priority: mediumReal value, no hard deadline; normal backlog flow.Real value, no hard deadline; normal backlog flow.

    on Oct 26, 2026
11. melodic-automation-lanes

    added

    status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.

    and removed

    status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

    on Oct 26, 2026
12. melodic-automation-lanes commented on Oct 26, 2026

    

    melodic-automation-lanesBot

    on Oct 26, 2026

    Contributor

    More actions

    Not admitted to the issue lane: no trusted-human acceptance criteria: a listed human must put the confirmed - [ ] criteria in the body or post them as their own comment, or, on an issue a listed human filed, intake's newest refinement comment must hold them unedited. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).
13. melodic-automation-lanes commented on Oct 26, 2026

    

    melodic-automation-lanesBot

    on Oct 26, 2026

    Contributor

    More actions

    The latest triage verdict holds nothing: admission moved the issue to status: confirmed; its comment says why.
14. melodic-automation-lanes

    added

    status: needs-decisionAwaiting a human or maintainer judgment call.Awaiting a human or maintainer judgment call.

    on Oct 26, 2026
15. melodic-automation-lanes commented on Oct 26, 2026

    

    melodic-automation-lanesBot

    on Oct 26, 2026

    Contributor

    More actions

    Refinement. A read-only run explored this repository, searched its issues and pull requests, and read the allowed docs to draft what follows. On an issue a listed human filed, it counts as the issue's spec once posted, while unedited; it is still model text, so check it.

    Intended outcome: The three merge-side readers and ci-workflows hold.cjs take a cost decision's decided head from the sha in the review lane's vetted claude-lane-hold check-run annotation, and no longer read a github-actions[bot] comment for it.

    Dependencies

    • ci-workflows release of the hold.cjs carryDecision change, then a re-pin of the review callers here, so the readers stay in agreement

    Related work

    • fix(pr-merge): bind a cost decision to the pull request it names #9569 (related): Introduced the comment-based same-head carry this issue hardens; P3 was found in its security review.
    • fix(ci): clear a cost-only review hold the owner already decided #9408 (related): Added the cost-only review hold clear in ci-status, which is the lift this issue changes.
    • fix(ci): ci-status's hold-lift window counts a removal made through an App #9520 (related): Open issue on the same ci-status hold-lift step; a change there could overlap.

    Open questions

    1. hold.cjs carryDecision lives in the ci-workflows repo, which is not in this checkout, so a run here cannot edit or check it. Should this issue cover only the three in-repo readers, with the hold.cjs change filed in ci-workflows plus a re-pin here?
       RECOMMENDED: Yes. Limit this issue to babysit_merge_policy.cost_decision, merge-holds.mjs costDecision and the ci-status lift, and file hold.cjs in ci-workflows. Basis: judgment; no hold.cjs under the checkout, and pr-require-checks.yml:3783 says the lift mirrors ci-workflows v0.65.4's hold step
    2. The fix edits .github/workflows, which the lanes App cannot push, and the owner's session is building it. Should the issue lane attempt it?
       RECOMMENDED: No. Keep it with the owner's session and keep agent-ready off. Basis: comment by kyle-sexton 2026-10-26T04:01:56Z citing patch-rules.json:3
    3. The annotation has sha and criteria but the readers also need the decision-time ordering the comment gave (costMarker's created_at cutoff, and the edited/deleted checks). Which replaces them: the check-run completed_at, or drop them since the annotation is vetted?
       RECOMMENDED: Use the check-run completed_at for the before-decision cutoff and drop the edit and delete checks, since a vetted annotation cannot be edited as a comment can. Basis: merge-holds.mjs:508 costMarker and merge-holds.mjs:594-602 edit and delete checks; judgment

    Sources read

    • context.json: issue 9635 body and comments
    • /home/runner/work/claude-code-plugins/claude-code-plugins/.base/.github/scripts/pr-merge/merge-holds.mjs:508: costMarker reads the newest github-actions[bot] comment matching the claude-lane-hold marker with criteria containing cost
    • /home/runner/work/claude-code-plugins/claude-code-plugins/.base/.github/scripts/pr-merge/merge-holds.mjs:603: carries uses marker.sha as the decided head and compares against head
    • /home/runner/work/claude-code-plugins/claude-code-plugins/.base/.github/workflows/pr-require-checks.yml:3758: the lift reads holds from the annotation notice but the decided head from the bot comment (3778)

    _{Automated refinement by the lanes App. Answer with a comment whose first line is **Decision recorded.**.}
16. kyle-sexton

    closed this as completedin ci-workflows#904on Oct 28, 2026
17. kyle-sexton commented on Oct 29, 2026

    

    kyle-sexton

    on Oct 29, 2026

    MemberAuthor

    More actions

    Re-triage. Not an owner stop. This is hardening that narrows what a comment can decide and widens nothing, and the builder was already named on 2026-10-26 (#9635 (comment)). The leftover status: needs-decision label comes off.

    Progress, checked against origin/main at 1ac46f0:

    • Done: PR fix(pr-merge): take a cost decision's decided head from the review lane's check-run annotation #10357 (merge commit 6e004b0) moved all three merge-side readers to the review lanes' vetted check-run notices: babysit_merge_policy.cost_decision, merge-holds.mjs costDecision, and the ci-status lift in pr-require-checks.yml. It dropped the comment read and its edit and delete checks. The PR used Refs:, leaving the ci-workflows half to close this issue.
    • Open: in melodic-software/ci-workflows, carryDecision in .github/actions/apply-review-hold/hold.cjs (about lines 238-259) still takes the decided head from the newest unedited github-actions[bot] marker comment.

    The refinement's questions, settled: (1) the ci-workflows change is built in that repository, then the review callers here are re-pinned; (2) the issue lane does not take it; (3) the before-decision cutoff uses the status job's completion time, and the comment edit and delete checks go, as #10357 did on the merge side.

    Build: the Automation Lanes session. The change lands in another repository, and the re-pin edits .github/workflows here, which the lanes App cannot push (.github/actions/resolve-config/patch-rules.json:3). agent-ready stays off.

    Acceptance criteria:

    • ci-workflows hold.cjs carryDecision reads the decided head with the same rule as fix(pr-merge): take a cost decision's decided head from the review lane's check-run annotation #10357: vetted pull_request runs of both review lanes that started before the decision, status-job notices whose sha= is their run's own head, the newest notice deciding, and nothing carried when two heads were noticed at that time. It reads no github-actions[bot] comment for it, and the change has tests in ci-workflows.
    • A ci-workflows release carries that change, and this repository's review-lane callers pin that release.
    • One case is checked across the four readers: a marker comment naming an unpushed head carries no cost decision in any of them.
18. kyle-sexton

    removed

    status: needs-decisionAwaiting a human or maintainer judgment call.Awaiting a human or maintainer judgment call.

    on Oct 29, 2026
19. kyle-sexton

    added 2 commits that reference this issue on Oct 29, 2026

    fix(runner-policy): approve pr-review-cli.yml v0.66.1 contract with s…

    ...

    63cafbf

    fix(claude-lanes): biome-format policy.json after the re-pin lockstep (…

    ...

    2c4e23b