pr-pipeline: give fix-docs a docs-only patch row #8956

Activity

1. kyle-sexton

   added

   priority: lowNice-to-have, cosmetic, or speculative; opportunistic.Nice-to-have, cosmetic, or speculative; opportunistic.

   on Oct 22, 2026
2. github-actions commented on Oct 22, 2026

   

   github-actionsBot

   on Oct 22, 2026 – with GitHub Actions

   Last edited by melodic-automation-lanes

   Contributor

   More actions

   Proposed work class: work-class: scoped
   Basis: automated intake triage; the lanes App applied this class.

   Size: Small
   Complexity: Low
   Uncertainty: Known
   Flags: none
   Blocked by: none

   Understood: fix-docs currently falls back to the default row in patch-rules.json, which allows more paths than a markdown-only lane needs. The proposal is a docs row (allow **/*.md; refuse skills/** and SKILL.md), patch-prepare: docs in pr-refine.yml's apply-patch job, and tests for the refused paths. The issue is specific enough to act on. I found no likely duplicates.

   _{Automated triage, applied by the lanes App.}
3. github-actions

   added

   needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.

   on Oct 22, 2026
4. github-actions

   added the

   Task

   issue type on Oct 22, 2026
5. kyle-sexton

   removed

   needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.

   on Oct 25, 2026
6. kyle-sexton commented on Oct 25, 2026

   

   kyle-sexton

   on Oct 25, 2026

   MemberAuthor

   More actions

   Released for re-triage under the owner's 2026-10-24 rule: an issue stops for a person only for an intent or vision question, a security call, a host or attended run, or spend outside prepaid credit. The hold label came off and intake triage runs again now; it re-applies a hold, with a numbered question, when one of those applies.

   To hold this issue again, add needs-human (or status: needs-decision) and say why in a comment.
7. github-actions

   added

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   and removed

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 25, 2026
8. melodic-automation-lanes

   added

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.

   status: needs-decisionAwaiting a human or maintainer judgment call.Awaiting a human or maintainer judgment call.

   and removed

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   on Oct 25, 2026
9. melodic-automation-lanes commented on Oct 25, 2026

   

   melodic-automation-lanesBot

   on Oct 25, 2026

   Contributor

   More actions

   Not admitted to the issue lane: no trusted-human acceptance criteria: a listed human must put the confirmed - [ ] criteria in the body or post them as their own comment, or, on an issue a listed human filed, intake's newest refinement comment must hold them unedited. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).
10. melodic-automation-lanes commented on Oct 25, 2026

    

    melodic-automation-lanesBot

    on Oct 25, 2026

    Contributor

    More actions

    The latest triage verdict holds nothing: admission moved the issue to status: needs-decision; its comment says why.
11. melodic-automation-lanes commented on Oct 25, 2026

    

    melodic-automation-lanesBot

    on Oct 25, 2026

    Contributor

    More actions

    Refinement. A read-only run explored this repository, searched its issues and pull requests, and read the allowed docs to draft what follows. On an issue a listed human filed, it counts as the issue's spec once posted, while unedited; it is still model text, so check it.

    Intended outcome: fix-docs's apply-docs-patch job uses a new docs row in patch-rules.json that admits only Markdown paths and refuses skills/** and any SKILL.md, with tests covering the refusals.

    Acceptance criteria

    • patch-rules.json has a docs row with the universal refuse list plus new refusals for skills/** and any SKILL.md (any case, any depth), and an allow rule matching only **/*.md
    • patch-rules.schema.json lists the docs row under properties and the new allow and refuse names in their enums with descriptions, and the schema validates patch-rules.json
    • predicates.mjs implements the new markdown allow predicate; the refusals are implemented where apply-patch.mjs evaluates the named refusals
    • pr-refine.yml's apply-docs-patch job passes patch-prepare: docs, and the comment above that job no longer says it uses the default row
    • pr-run-activity-write.yml accepts docs as a patch-prepare value and its input doc lists it, if the input is validated or documented there
    • an apply-patch test shows a patch changing a non-markdown path (for example a .json or .mjs file) under the docs row is refused with patch-protected-path
    • an apply-patch test shows a patch touching skills/<name>/SKILL.md or any other SKILL.md under the docs row is refused, and a patch touching only a .md file outside skills/ is admitted
    • a callers.test.mjs assertion shows apply-docs-patch passes patch-prepare docs
    • docs/conventions/pr-pipeline/pr-run-activity.md (near line 1357) and the Patch rules section of README.md describe the docs row instead of the default row for fix-docs, and CHANGELOG.md gets an entry
    • the repository's resolve-config and apply-patch test suites pass

    Dependencies

    • none blocking; the follow-up to reconsider fix-docs web access is separate and waits on this landing

    Related work

    • feat(pr-pipeline): run fix-docs on run-claude-cli with an apply-patch push job #8964 (related): merged PR that moved fix-docs onto run-claude-cli with the apply-docs-patch push job under the default row
    • fix(pr-pipeline): run fix-docs in dontAsk with explicit allow rules #9060 (related): merged PR that runs fix-docs in dontAsk with explicit allow rules, same lane

    Sources read

    • .github/actions/resolve-config/patch-rules.json:53: the default row allows ["any"] with only the universal refusals; no docs row exists
    • .github/actions/resolve-config/patch-rules.schema.json:44: allow is an enum of any, kept-threads, dependency-manifests, merge-result, so a markdown-only rule needs a new predicate; refuse enum at :28 has no skills/SKILL.md names
    • .github/scripts/apply-patch/predicates.mjs:9: PREDICATES map where a new markdown predicate goes
    • .github/workflows/pr-refine.yml:225: the push job is named apply-docs-patch, not apply-patch, and passes no patch-prepare
    • docs/conventions/pr-pipeline/pr-run-activity.md:1357: documents fix-docs as taking the default row

    _{Automated refinement by the lanes App. Admission counts only criteria a listed human wrote: to confirm these, post them as your own comment whose first line is **Decision recorded.**, which sends the issue back through intake.}