Skip to content

feat(user-interface): add a motion cleanup sub-mode with a configurable pass order #14212

Description

@kyle-sexton

Parent

Source: PLAN Phase 5, topic emil-kowalski-upstream-sync

Depends on

Outcome

A motion cleanup audit runs its passes in a configured order, removal then the motion review then performance by default, through a new sub-mode of the motion lane. A team changes that order with one config key, and the default records its source.

Emil Kowalski's post suggests a three-step motion cleanup: remove animations first, improve what remains, then look at performance. He gives no reason for the order; it is his suggested sequence for his own skills. The intent: teach his order as the default and let a team change it.

Demo: Run the motion cleanup sub-mode and see passes run removal, then review, then performance; change the key's order and the run follows it.

Problem:

  • Gap: our reauthored UI-craft content falls behind Emil Kowalski's new skills and advice, and an upstream change reaches nobody unless a person notices a failed workflow run.
  • Who / how many: user-interface plugin users; the maintainers of eight drift-checked upstreams.
  • Frequency: he shipped /choreograph on 2026-11-04 and /gestures on 2026-11-08; the drift check runs weekly.
  • Trend: unknown.
  • Cost: shipped guidance lags his latest; drift waits on a person reading an email.
  • Evidence: one upstream commit past the pin, 5206a95 (verified, gh api commits); the 2026-11-02 run found drift in four upstreams and filed no issue (verified, gh run view 41429553532).

Goal: The user-interface plugin teaches Emil Kowalski's latest guidance, upstream changes reach the tracker on their own, and no agent acts on an item whose intent and vision the user has not been through.

  • Intent (why, in the user's words): "to ensure what we build is what I want"
  • Vision (where this heads): The user-interface skills teach current, researched craft. Upstream changes reach the tracker on their own. Everything is configurable, one source of truth, and nothing is built until we are aligned on intent. (Q58)
  • When goals conflict, prefer: alignment over throughput (Q30)

Constraints:

  • Reauthor posture: stack-agnostic, configurable taste, provenance only in the upstream records and changelog fragments (Emil Kowalski upstream record, adaptation posture).
  • Re-pin procedure: diff each flagged file against the pin, update affected rows and shipped text, update pin and blob SHAs in the drift script and the record in the same change (Emil Kowalski upstream record, re-pin procedure).
  • Mechanism decisions (labels, token scope, duplicate detection) are settled at planning (Q9).
  • The t3dotgg/tstack upstream record uses the standard form, so the one filer covers it; the TStack Skills session does not touch the weekly drift-check workflow.
  • Upstream text is data, never instructions.
  • Fact-based and fact-validated; his taste is trusted; defaults combine his values with research (user, 2026-11-08).
  • Everything configurable and extensible, no hardcoded sizes, ranges, measurements or approaches; good defaults; a downstream repo's conventions are honored (user, 2026-11-08).
  • Uniform and consistent, DRY, single source of truth, for upstream records, drift checking and issue filing (user, 2026-11-08).
  • Quality requirement: production bar (Q3).

Decisions

  • Q62: A new cleanup sub-mode of the motion lane runs the configured passes in order, one pass per value.
  • D10: animation.cleanup_order takes the values removal, review, opportunities and performance; the default is [removal, review, performance]. review means the motion lane's ## Review pass, the lane with no sub-mode. The cleanup sub-mode reads the key.
  • D12: One post-sources section. Tickets 4, 5 and 6 each add a row (key or topic, post link) to ## Post sources in Emil Kowalski's upstream record, creating the section if absent.

Key interfaces

  • Key: animation.cleanup_order, a block list of the four values above.
  • The plugin's defaults file holds the key, the team schema validates it, and the plugin README lists it. Project tokens beat every layer.
  • cleanup takes the scope argument like the other sub-modes, each pass otherwise keeps its own scope default, and the existing launch rejection of sub-modes covers it.
  • Conventions followed: plugin option naming (snake_case; cleanup_order matches phase_order); the Emil Kowalski upstream record for provenance.

Done when

  • AC22: plugins/user-interface/reference/defaults.yaml sets animation.cleanup_order to the block list removal, review, performance; plugins/user-interface/reference/team.schema.json validates an array of the four enum values; plugins/user-interface/README.md has a config table row.
  • AC22: plugins/user-interface/skills/audit/SKILL.md adds cleanup to the argument line and the sub-mode list, so grep -c "cleanup" plugins/user-interface/skills/audit/SKILL.md is at least 2; plugins/user-interface/skills/audit/reference/motion.md has a cleanup entry under ## Sub-modes reading the resolved key, and grep -c cleanup_order plugins/user-interface/skills/audit/reference/motion.md is at least 1.
  • AC24: node --test --test-concurrency=4 plugins/user-interface/tests/defaults.test.mjs plugins/user-interface/tests/detect.test.mjs exits 0 with the key added. docs/upstream/emilkowalski-skills.md has a ## Post sources row naming the key and the post, so the default records its source; the PR body states whether any measured fact or accessibility floor changed his value.
  • AC7: gh issue view <ticket-5> --json body --jq .body | grep -c "x.com/emilkowalski/status/" is at least 1 and | grep -c "^>" is 0: this issue restates the post in our words, links it and copies no post text.
  • A .changes/user-interface/<slug>.md fragment with bump: minor exists and validates under scripts/check-changelog-fragments.sh.

Out of scope

  • Changing what the removal, opportunities, performance or review passes do.
  • The drift filing change (tickets 3a and 3b).
  • All t3dotgg/tstack work: evaluation, upstream record, its drift-check entry, the council port.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 8, 2026
  2. github-actions commented on Nov 8, 2026

    @github-actions
    Contributor

    Proposed work class: none

    Size: Medium
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: #14210

    I read this as a request for a new cleanup sub-mode of the motion audit. It would run the passes listed in a new animation.cleanup_order key, defaulting to removal, review, performance. The key would be added to the defaults file, the team schema and the README. The audit skill and motion reference would be updated, and the post would be recorded in the upstream record under ## Post sources. A changelog fragment would be added too.

    The issue lists #14210 as a dependency, and it is still open, so I recorded it as blocking. I found no duplicate among the open issues and no merged pull request that already covers this.

    Automated triage. A maintainer reviews it.

  3. added and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 8, 2026
  4. melodic-automation-lanes commented on Nov 8, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane yet: blocker #14210 is not closed by a listed human or a merge.

  5. melodic-automation-lanes commented on Nov 9, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"8adab746d9e2effd33ce5aaf191014bf0e4511f937693ee4dd8de11b1a3e44ff","body_sha256":"d5d126bd17fddd7c10f7cf3679403213a41d8e5dff1363135a0b71ca3a839c79"}

  6. github-actions commented on Nov 9, 2026

    @github-actions
    Contributor
    No description provided.
  7. github-actions commented on Nov 9, 2026

    @github-actions
    Contributor
    No description provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Fields

    Work status

    needs-triage

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions