ci: switch ci-status's hold-label and kill-switch checks to merge-holds.mjs labelHolds and switchHold #10835

Activity

1. github-actions

   added

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 29, 2026
2. github-actions commented on Oct 29, 2026

   

   github-actionsBot

   on Oct 29, 2026 – with GitHub Actions

   Last edited by melodic-automation-lanes

   Contributor

   More actions

   Proposed work class: work-class: scoped
   Basis: automated intake triage; the lanes App applied this class.

   Size: Medium
   Complexity: Medium
   Uncertainty: Known
   Flags: none
   Blocked by: none

   Understood: once the #10747 change is on main, replace the two bash hold checks in ci-status (hold labels and the lanes kill switch) with the base module's labelHolds and switchHold. The change keeps the current error texts, fails closed when the module can't judge, and updates the two hold test scripts. The aim is that the rules are stated once and every state that fails today still fails. The approach and done-when are clear. I found no likely duplicates among the open issues.

   _{Automated triage, applied by the lanes App.}
3. github-actions

   added

   priority: mediumReal value, no hard deadline; normal backlog flow.Real value, no hard deadline; normal backlog flow.

   and removed

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 29, 2026
4. github-actions

   added the

   Task

   issue type on Oct 29, 2026
5. melodic-automation-lanes

   added

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.

   status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.

   and removed

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   on Oct 29, 2026
6. melodic-automation-lanes commented on Oct 29, 2026

   

   melodic-automation-lanesBot

   on Oct 29, 2026

   Contributor

   More actions

   Not admitted to the issue lane: no trusted-human acceptance criteria: a listed human must put the confirmed - [ ] criteria in the body or post them as their own comment, or, on an issue a listed human filed, intake's newest refinement comment must hold them unedited. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).
7. melodic-automation-lanes commented on Oct 29, 2026

   

   melodic-automation-lanesBot

   on Oct 29, 2026

   Contributor

   More actions

   The latest triage verdict holds nothing: admission moved the issue to status: confirmed; its comment says why.
8. melodic-automation-lanes commented on Oct 29, 2026

   

   melodic-automation-lanesBot

   on Oct 29, 2026

   Contributor

   More actions

   Refinement. A read-only run explored this repository, searched its issues and pull requests, and read the allowed docs to draft what follows. On an issue a listed human filed, it counts as the issue's spec once posted, while unedited; it is still model text, so check it.

   Intended outcome: After the #​10747 change is on main, ci-status's two hold steps call the base merge-holds.mjs labelHolds and switchHold, failing closed, with the same error texts and updated hold test scripts.

   Related work

   • ci: fail held merge-queue pull requests before the lane legs run #10747 (related): Open prerequisite; it adds labelHolds and switchHold to merge-holds.mjs, and neither is on main yet.
   • fix(pr-pipeline): end designed stops cleanly and keep held pull requests out of the merge queue #10737 (related): Merged first step of the same two-step pattern for the pr-unblock rule.
   • fix(ci): fail ci-status when the kill switch stopped a review lane #9836 (related): Added the kill-switch failure in ci-status that this issue would move into the module.

   Open questions

   1. Should this wait until the #​10747 pull request merges, since labelHolds and switchHold are not yet in merge-holds.mjs on main?
      RECOMMENDED: Yes. Keep the issue held and re-refine once #​10747 is merged, when the exported signatures and return shapes can be read and the criteria can name them. Basis: .base/.github/scripts/pr-merge/merge-holds.mjs has no labelHolds or switchHold (grep finds 0 matches); #​10747 is open.
   2. How should the human-gated label name reach labelHolds? ci-status now reads role_labels.human-gated from the base .work-item-tracker.json and defaults to needs-human.
      RECOMMENDED: Keep the tracker read in the step, or have labelHolds read it from the base-config checkout; either way fail closed on an unreadable tracker. Basis: .github/workflows/pr-require-checks.yml:4783

   Sources read

   • .github/workflows/pr-require-checks.yml:4761: the label-hold step is bash and checks do-not-merge, the human-gated label and pr-verify-failed, each with its error text
   • .github/workflows/pr-require-checks.yml:5200: the kill-switch check is bash and fails unless both variables read false
   • scripts/ci-hold-merge-group.test.sh:32: runs the label-hold step body
   • scripts/ci-lanes-pr-hold.test.sh:35: runs the lanes hold step body

   To answer, post a comment that starts with this line:

   **Decision recorded.** <answer>
   

   _{Automated refinement by the lanes App. Answer with a comment whose first line is **Decision recorded.**.}
9. melodic-automation-lanes

   added

   status: needs-decisionAwaiting a human or maintainer judgment call.Awaiting a human or maintainer judgment call.

   on Oct 29, 2026
10. kyle-sexton

    closed this as completedin #10876on Oct 29, 2026