feat(pr-merge): remove the lane's own hold-path needs-human label after a trusted approval lifts the hold #10785

Activity

1. github-actions

   added

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 28, 2026
2. github-actions commented on Oct 28, 2026

   

   github-actionsBot

   on Oct 28, 2026 – with GitHub Actions

   Last edited by melodic-automation-lanes

   Contributor

   More actions

   Proposed work class: work-class: scoped
   Basis: automated intake triage; the lanes App applied this class.

   Size: Medium
   Complexity: High
   Uncertainty: Known
   Flags: none
   Blocked by: none

   Understood: when a trusted person's approval lifts a hold path on a lanes App pull request, enable-auto-merge should remove the needs-human label it added, but only under strict provenance, no-other-escalation and head re-read checks. Otherwise the label stays, and a report-only run deletes nothing. The body's criteria and the refinement comment's testable criteria are specific enough to start from. #9437 is related (same label's ownership rules), but it is not a duplicate.

   _{Automated triage, applied by the lanes App.}
3. github-actions

   added

   priority: mediumReal value, no hard deadline; normal backlog flow.Real value, no hard deadline; normal backlog flow.

   and removed

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 28, 2026
4. github-actions

   added the

   Feature

   issue type on Oct 28, 2026
5. melodic-automation-lanes

   added

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.

   status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.

   and removed

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   on Oct 28, 2026
6. melodic-automation-lanes commented on Oct 28, 2026

   

   melodic-automation-lanesBot

   on Oct 28, 2026

   Contributor

   More actions

   Not admitted to the issue lane: no trusted-human acceptance criteria: a listed human must put the confirmed - [ ] criteria in the body or post them as their own comment, or, on an issue a listed human filed, intake's newest refinement comment must hold them unedited. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).
7. melodic-automation-lanes commented on Oct 28, 2026

   

   melodic-automation-lanesBot

   on Oct 28, 2026

   Last edited by melodic-automation-lanes

   Contributor

   More actions

   The latest triage verdict holds nothing: the issue is at status: ready.
8. melodic-automation-lanes

   added

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   and removed

   status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.

   on Oct 28, 2026
9. melodic-automation-lanes commented on Oct 28, 2026

   

   melodic-automation-lanesBot

   on Oct 28, 2026

   Contributor

   More actions

   Refinement. A read-only run explored this repository, searched its issues and pull requests, and read the allowed docs to draft what follows. On an issue a listed human filed, it counts as the issue's spec once posted, while unedited; it is still model text, so check it.

   Intended outcome: On a reader run, enable-auto-merge deletes the lane's own needs-human label from a lanes App pull request once a trusted person's approval lifts the hold path, under the stated provenance, no-other-escalation and head re-read checks, and otherwise keeps it.

   Acceptance criteria

   • With REPORT_ONLY not false, enable-auto-merge issues no label delete and logs it would (a test asserts no DELETE call).
   • A test passes where the newest refusal names only hold paths, no cost hold stands, the file listing was read whole, and a trusted person's approval is bound to the head: the needs-human label is deleted.
   • A test passes where the approval is carried under the merge-holds carry rules (an earlier head whose every change since is a base merge): the label is deleted.
   • A test passes where the newest labeled event for the label is by a person, or is the App's but unpaired with enable-auto-merge's refusal comment: the label stays.
   • A test passes where a refusal names a cost hold or a non-hold-path reason, or the file listing was cut short: the label stays.
   • A test passes where a review-lane hold comment or a check-signed-commits hold comment was written or edited since the label was last removed: the label stays.
   • A test passes where, since the label went on, the App wrote a pr-unblock escalation or any other marked comment: the label stays.
   • A test passes where, since the label went on, a person commented, replied in a review thread, or submitted a non-approving review: the label stays; an approval alone does not keep it.
   • A test passes where any read fails, or the head read again before the delete differs from the judged head: the label stays.
   • A test passes where a delete is made at the judged head, and docs/conventions/pr-pipeline/README.md and its CHANGELOG.md describe the new removal, citing that pr-require-checks.yml re-runs ci-status on unlabeled.
   • The new logic reuses the existing provenance and marker rules of .github/scripts/pr-merge/clear-escalations.mjs and merge-holds.mjs rather than a second copy, and the existing pr-merge script tests still pass.

   Related work

   • feat(pr-pipeline): hold lanes App human-merge pull requests with a label only a listed human can remove #9437 (related): open issue on holding lanes App human-merge PRs with a label only a listed human can remove; it touches the same label's ownership rules
   • feat(pr-pipeline): merge lanes App pull requests through native auto-merge #9508 (related): merged-closed PR that moved lane PRs to native auto-merge through enable-auto-merge, the script this changes

   Sources read

   • .github/scripts/pr-merge/enable-auto-merge.mjs:1115: REPORT_ONLY === "false" is the only write mode; humanGated label comes from the tracker config at line 1119
   • .github/scripts/pr-merge/enable-auto-merge.mjs:1212: refusalWrites adds the human-gated label and the refusal comment on a hold
   • .github/scripts/pr-merge/clear-escalations.mjs:6: removes only an App-set label under paired-comment, no-review-hold, no-person-activity rules; the pattern to reuse
   • .github/scripts/pr-merge/clear-escalations.mjs:73: a pr-merge escalation clears as head-moved only; it does not clear on a trusted approval, which is the gap
   • .github/scripts/pr-merge/merge-holds.mjs:1186: ci-status's hold-path reason says an approving review of this head by a trusted-actor person lifts it
   • .github/scripts/pr-merge/merge-holds.mjs:1374: ci-status logs the lifters and how the approval lifts a hold path

   _{Automated refinement by the lanes App. Intake triages the issue again with it.}
10. github-actions

    removed

    needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

    on Oct 28, 2026
11. melodic-automation-lanes

    added

    status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.Admitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.

    on Oct 28, 2026
12. kyle-sexton

    closed this as completedin #10737on Oct 29, 2026