fix(pr-merge): keep a cost hold when a newer lane run was deleted #10437

Activity

1. github-actions

   added

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 27, 2026
2. github-actions commented on Oct 27, 2026

   

   github-actionsBot

   on Oct 27, 2026 – with GitHub Actions

   Last edited by melodic-automation-lanes

   Contributor

   More actions

   Proposed work class: work-class: scoped
   Basis: automated intake triage; the lanes App applied this class.

   Size: Medium
   Complexity: Medium
   Uncertainty: Knowable
   Flags: none
   Blocked by: none

   Understood: after #10357, a cost decision's decided head comes from the newest lane run's cost notice. If a newer lane run is deleted, an older notice can be promoted to the decided head. You want the cost hold to compare the PR's head history against the lane runs per head, so it stays when a head has no lane run. The rule would be shared across merge-holds.mjs, babysit_merge_policy.py and the ci-status step, with tests for both the deleted-run and no-deletion cases. No duplicates found among the open issues.

   _{Automated triage, applied by the lanes App.}
3. github-actions

   added

   priority: mediumReal value, no hard deadline; normal backlog flow.Real value, no hard deadline; normal backlog flow.

   and removed

   needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.

   on Oct 27, 2026
4. github-actions

   added the

   Bug

   issue type on Oct 27, 2026
5. melodic-automation-lanes

   added

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.

   agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.Fully specified and briefed; eligible for autonomous pickup from the frontier.

   needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.

   and removed

   agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.Fully specified and briefed; eligible for autonomous pickup from the frontier.

   on Oct 27, 2026
6. melodic-automation-lanes commented on Oct 27, 2026

   

   melodic-automation-lanesBot

   on Oct 27, 2026

   Contributor

   More actions

   The work-resolve-issue lane stopped partway through this issue and needs a person.

   Why, in the run's own words:

   The run stopped early (patch-protected-path): its change needs a path the issue lane may not push, which a person changes instead. In the run's words: patch-protected-path: .github/workflows/pr-require-checks.yml. The issue's first Done-when item requires the detector to be mirrored in the ci-status cost-hold step ('Clear a cost-only review hold the owner decided', id cost_hold). That step's carries() function, which derives the decided head, sits inline in .github/workflows/pr-require-checks.yml (around line 4049), so the lane cannot push that change. Also, the issue assumes ＃10357's design, which takes the decided head from the review lane's check-run notice. ＃10357 is still open (labeled do-not-merge and needs-human) and is not on this branch. Here the decided head still comes from the newest github-actions[bot] cost hold comment (merge-holds.mjs costMarker), and a deleted newer marker is already caught by deletedSince. A lane-run deletion detector has nothing to attach to until ＃10357 lands. This needs a person: land ＃10357 first, then run this issue from a context that may edit pr-require-checks.yml.

   What the run says it did not do:

   • Detector in merge-holds.mjs, babysit_merge_policy.py and the ci-status cost-hold step: not started, because the cost-hold step is in protected .github/workflows/pr-require-checks.yml and the lane-run-notice base from ＃10357 is not merged
   • Tests (a deleted newer lane run keeps the hold; an undeleted decision still clears): not written, for the same reason
   • PR prep review, build/test and lint: skipped because the tree has no changes

   Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40460183934

   To retry, remove needs-human and add agent-ready again.
7. kyle-sexton commented on Oct 27, 2026

   

   kyle-sexton

   on Oct 27, 2026

   MemberAuthor

   More actions

   Routed to a builder. #10357 merged at 2026-10-27T17:27Z, so the PR this issue was waiting on is no longer open. What still stops the issue lane is the protected path its first Done-when item needs: .github/workflows/pr-require-checks.yml (run 40460183934, patch-protected-path). The lanes App cannot push a workflow file, and none of the owner's reasons applies: the change tightens a cost hold, it does not loosen one.

   • Builder: Automation Lanes (workflow edits; merge-holds.mjs and the ci-status cost-hold step).
   • needs-human comes off and status: confirmed goes on; agent-ready stays off, so the issue lane does not pick it up again.
   • The Done-when list above is unchanged.
8. kyle-sexton

   added

   status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.

   and removed

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.

   on Oct 27, 2026
9. kyle-sexton

   closed this as completedin #10515on Oct 27, 2026