Skip to content

pr-review-cli: a failed publish leaves the status check green #867

Closed

Description

@kyle-sexton

Problem

In pr-review-cli.yml (v0.63.1), a failed publish leaves the lane's status check green. The review ran, but no review, summary or marker reached the PR.

Seen on claude-code-plugins#9307 at head d714aaa. The publish step failed with "API rate limit exceeded for installation" (failure-class=publish-failed), and the status check still concluded success (job 120258309454 annotations). Re-running the job published normally.

The caller's revert rule (revert on a red status, or on no summary posted for a head, twice in a row) relies on a missing summary showing as a red check. Babysit reads a green check plus a missing record as no-record, which holds the PR. So nothing merges wrongly, but the hold carries no reason a person can see.

Fix

The status job fails, naming publish-failed, whenever the publish step did not finish. Optionally, retry the publish on a rate-limit error with script backoff before failing. Add a test: a forced publish failure ends the status job red.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 23, 2026
  2. kyle-sexton commented on Oct 23, 2026

    @kyle-sexton
    MemberAuthor

    Fixed by #868, released in v0.64.1 (9aca743). Live proof: melodic-software/claude-code-plugins run 39931559612 (security lane, v0.64.1) hit 'API rate limit exceeded for installation' while publishing. Its status check ended red with failure-class=publish-failed, where v0.63.1 left it green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-triageNot yet classified. Floor until a type and one priority tier are set.

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions