Repository navigation
Support exact Rational{BigInt} distances - #29
Merged
Merged
Conversation
The distance kernels now run on `Rational{BigInt}` coordinates and give
exact results, useful as a reference. With floats, degenerate simplexes
give NaN or infinite weights that `clamp01nan` makes points of the
simplex, but rationals throw on `0//0`. `_clamp01_div` and `_inv0` give
zero there instead. Float32 and Float64 results are unchanged.
A new test checks the exact results: `d2` is the minimum when every
vertex of each simplex is on the far side of the plane through its
closest point, perpendicular to `r`.
Bump the version to 0.3.1-dev.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distance kernels now run on
Rational{BigInt}coordinates and give exact results, useful as a reference. With floats, degenerate simplexes give NaN or infinite weights thatclamp01nanmakes points of the simplex, but rationals throw on0//0._clamp01_divand_inv0give zero there instead. Float32 and Float64 results are unchanged.A new test checks the exact results:
d2is the minimum when every vertex of each simplex is on the far side of the plane through its closest point, perpendicular tor.Bump the version to 0.3.1.