Repository navigation
Loosen the distance contract to 64 eps and add the cases over 8 - #26
Merged
Merged
Conversation
A point on the face of a triangle with coordinates near 1e7 came out 8.07*eps*ℓ off, and a search found a line segment pair 8.12*eps*ℓ off. Each error is a few roundings of lengths up to 2√3*ℓ, so 8 is too tight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The docstring promised exact closest points. Add the error bound on d², the bounds on the weights, the coordinate range they hold in, and the NaN behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A point on the face of a triangle with coordinates near 1e7 came out 8.07epsℓ off, and a search found a line segment pair 8.12epsℓ off. Each error is a few roundings of lengths up to 2√3*ℓ, so 8 is too tight.