Conversation
Read color scheme keys from interactive example code blocks and pass the selected mode to the preview runner. Preserve existing light styling for unmarked examples while allowing opted-in examples to follow the MDN theme.
Contributor
|
b55a6f0 was deployed to: https://fred-pr1980.review.mdn.allizom.net/ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update tabbed interactive examples to support
light-dark,light, anddarkcode block keys. Unmarked examples retain their existing light appearance.Motivation
Allow authors to opt examples into dark mode without changing existing examples.
Additional details
The first color scheme key in an example's code blocks applies to the whole example. Browser coverage was added but could not be run locally because WebdriverIO stalled before launching geckodriver.
Related issues and pull requests
Related to #965.