Repository navigation
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
chrisdavidmills
approved these changes
Oct 16, 2026
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me; thanks, @ddbeck.
Elchi3
approved these changes
Oct 16, 2026
Elchi3
left a comment
Member
There was a problem hiding this comment.
Ah thanks for cleaning after the non-humans. 👍
ddbeck
deleted the
reconcile-webassembly.jspi-etc-chrome-for-androi/vsrnprvrrwzt
branch
October 16, 2026 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconcile Chrome for Android's support for the WebAssembly JavaScript Promise Integration API.
Test results and supporting details
In #29783, compat keys were created that differed from the
webassembly.jspidata, showing that Chrome for Android doesn't support the API.I can't find any evidence this is true. The collector test run on Android shows that
webassembly.jspiis supported. A Chrome Status entry says there's Android support explicitly.Since #29783 is plainly not authored by a human, I don't think we should take that data seriously.
Including Chris and Florian as reviewers here, since they were reviewers on the previous PR.
Related issues
wasm-jspi: backfill compat keys web-platform-dx/web-features#4541