Skip to content

Align rename references with deterministic resolution #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
callumalpass wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −11
Open

Align rename references with deterministic resolution #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions tests/level-5/references.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,11 @@ groups:
tasks/task-b.md: |
---
type: task
id: "task-b"
title: "Task B"
---
tasks/task-c.md: |
---
type: task
id: "task-c"
title: "Task C"
parent: "[[task-b]]"
---
Expand Down Expand Up @@ -202,7 +200,6 @@ groups:
notes/target.md: |
---
type: note
id: "target"
title: "Target Note"
---

Expand Down Expand Up @@ -284,7 +281,6 @@ groups:
notes/target-note.md: |
---
type: note
id: "target-note"
title: "Target Note"
---
Some body content here.
Expand Down Expand Up @@ -554,10 +550,10 @@ groups:
link: "[Detail](../archive/detail.md)"

# =============================================================================
# Group 6: Ambiguous link handling during rename
# Group 6: Deterministic duplicate-filename handling during rename
# =============================================================================

- name: "ambiguous link not updated during rename"
- name: "deterministically selected duplicate filename updated during rename"
spec_ref: "§12.5"

setup:
Expand Down Expand Up @@ -594,7 +590,7 @@ groups:
---

tests:
- name: "ambiguous link emits warning and is not updated"
- name: "deterministically selected duplicate filename is updated"
operation: rename
input:
from: "folder-a/shared-name.md"
Expand All @@ -603,17 +599,18 @@ groups:
expect:
from: "folder-a/shared-name.md"
to: "folder-a/renamed.md"
warnings:
references_updated:
- path: "notes/source.md"
message_contains: "ambiguous"
# The ambiguous link is left unchanged
field: "ref"
# Equal-depth duplicate filenames use lexical normalized path order,
# so the link identifies folder-a/shared-name.md before the rename.
verify_after:
operation: read
input:
path: "notes/source.md"
expect:
frontmatter:
ref: "[[shared-name]]"
ref: "[[renamed]]"

# =============================================================================
# Group 7: rename_ref_update_failed error code
Expand Down