feat: Load ferry timetables from data#3206
Merged
Merged
Conversation
d3c8d4a to
12e73a6
Compare
12e73a6 to
df1f2a3
Compare
lvachon1
approved these changes
May 29, 2026
Contributor
lvachon1
left a comment
There was a problem hiding this comment.
This is some cool code, I like how generalized it is. I bet we'll find an exception to these elegant rules at some point, but I can see this being useful for more than just these loops. I think this kind of "merge schedules with different stops into a timetable" function would've made the weird WC CR shuttles trivial.
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🏖️⛴️ Update Quincy/Winthrop timetables to be data-based again
This is also a soft blocker for the Harbor Loop Ferry work, since this will allow us to not hard-code data for that timetable.
Implementation
Screenshots
How to test
Look at the Quincy and Winthrop timetables, and compare them against their production Quincy and Winthrop counterparts.