Repository navigation
fix(server): stop short network failures from failing sessions with 502 - #149
Merged
Merged
Conversation
mbroton
force-pushed
the
fix/server-dial-retry
branch
from
November 12, 2026 19:27
010e0e1 to
1a02d6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DNS or network failure shorter than one second made the relay fail new sessions with
502 Bad Gateway. The relay also marked the healthy workerstalleduntil its next heartbeat. Under load no other worker was free, so the client got the error.The relay now retries a failed connection to the same worker with a short backoff (about 1.5 s in total, inside
WORKER_DIAL_TIMEOUT). A temporary DNS error no longer stalls the worker. A worker that refuses connections or answers with an HTTP error is still stalled, and the session moves to a different worker as before. No configuration changes. TheWORKER_DIAL_TIMEOUTdocs now say that the limit includes retries.Verification: the new relay tests fail on
mainand pass here. In a local Compose load test with 0.5 s worker network drops,maingave 4 × 502 in 17 drops, and this branch gave 0 in 24.