mps-cli-py: extended SModel class to include imported models#63
Conversation
…ests for model imports
Prithvi686
left a comment
There was a problem hiding this comment.
Hi @btakim ,
The changes look good to me! Thanks for this extension, however I just have one small comment here - extract_imported_models() parses the same XML twice for every model I think - once in extract_model_core_info for the new imported_models field and again in extract_imports_and_registry for index_2_imported_model_uuid.
Not wrongg, just doing the same work twice. Could we pass the dict through instead of recomputing it? But I think we can also leave this as a follow-up and fix it later...
|
@Prithvi686 thanks for catching the issue, seperated registry extraction from model import extraction now. I think registry can also be part of the SModel later but for now that looks okey. I hope the change is satisfactory, please let me know if you have any further ideas for improvement. Thanks! |
@btakim thanks for the fix, it looks good to me now! |
There is a need to analyze imported models when the model is read to be able to get the right model dependency graph. Added tests for model imports.