Fix: CRC-16 checksum incorrect for non-ASCII characters#8
Open
BrookTV wants to merge 4 commits into
Open
Conversation
Owner
|
Thanks for the PR! I have two concerns I'd like to get your thoughts on
I'll look into this soon. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
From Issue
Fix
Fixes #7
Replace charCodeAt(0) with new TextEncoder().encode(data), which yields the actual UTF-8 byte sequence the EMVCo spec calls for. TextEncoder is a Web API available natively in Node.js 11+, all modern
browsers, Deno, and Bun — no polyfill needed.
tsconfig.json gains "DOM" in lib so TypeScript resolves the TextEncoder type.
Test
Added a test case that parses a PromptPay payload containing non-ascii characters in the merchant name field (tag 59) in strict mode (checksum validation on). The test was failing before this fix.