Skip to content

PR#38 add font-family and changed colors#38

Draft
lidwienl wants to merge 4 commits intomainfrom
feature/38-figma-font
Draft

PR#38 add font-family and changed colors#38
lidwienl wants to merge 4 commits intomainfrom
feature/38-figma-font

Conversation

@lidwienl
Copy link
Copy Markdown

Summary

changing the 'Voorbeeld' theme to OIP theme.

Copy link
Copy Markdown
Collaborator

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToDo:

"max-inline-size": {
          "$type": "dimension",
          "$value": "1440px"
        },

"default": {
"$type": "fontFamilies",
"$value": "IBM Plex Sans, sans-serif"
"$value": "Lato"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToDo: zoek uit of hier een waarde in kan worden ingevuld die in FIgma geen bestaand font is. Open Inwoner gebruikt hier het woord "Body" in plaats van Lato - omdat we geen font vast mogen zetten, zodat gemeente hun eigen fonts kunnen uploaden.

},
"md": {
"$type": "lineHeights",
"$value": "150%"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moet line-height in percentages? In CSS moet dat in vaste "unitless" notatie, dus 1,5 in plaats van 150%. Maar misschien kan style-dictionary dat niet verwerken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants