Repository navigation
ci: stop publishing the legacy mavsdk name - #830
Merged
Merged
Conversation
The last legacy 'mavsdk' release from this repo was 3.17.4. The name now belongs to the native binding, which already has 4.0.x releases on PyPI. Building it on the next tag would produce mavsdk-4.0.5-py3-none-*.whl. Those filenames don't clash with the native cp38-abi3 wheels, so --skip-existing would not skip them, and PyPI would add them to the native mavsdk 4.0.5 release. On platforms the native binding doesn't cover (armv6l, armv7l), 'pip install mavsdk' would then resolve to the gRPC wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy
mavsdkname had its last release from this repo with 3.17.4 (with the rename warning). The name now belongs to the native binding, which has already published 4.0.0 to 4.0.5.CI still builds both distributions on every tag. Tagging 4.0.5 would build
mavsdk-4.0.5-py3-none-*.whl. Those filenames don't clash with the nativecp38-abi3wheels, so--skip-existingwouldn't skip them, and PyPI would add them to the nativemavsdk 4.0.5release. On armv6l and armv7l, where the native binding has no wheel,pip install mavsdkwould then install the gRPC wrapper.This PR:
mavsdk-grpcin all four jobs (Linux x86_64, Linux armv6l/armv7l/aarch64, macOS, Windows).setup.pycomments to say the legacy name must not be published from here again.The
setup.pysupport forMAVSDK_DIST_NAME=mavsdkstays, but only an explicit opt-in builds it.Follow-up outside the repo: scope the
TWINE_PASSWORDtoken tomavsdk-grpconly, so CI cannot upload tomavsdkat all.