Repository navigation
Count two unknowns per patch in the sequential frequency loop - #45
Merged
maurymarkowitz merged 1 commit intoNov 21, 2026
Merged
Conversation
execute_frequency_loop_sequential() sized the system as N + M while num_eq_sym is NP + 2MP, so factor_block_matrix() reported SYMMETRY ERROR and onec exited 1 on every deck with a surface patch (a single SP is enough). NEC-2's NEQ is N + 2M, as process_deck_sequential() and control.c already compute. NEC-2 example 4 with its GX written out as eight explicit SPs now gives 180.728+j217.649 (nec2c 1.3.1: 180.73+j217.65). Example 4 as published, with GX 0 110 reflecting the patches, still disagrees (95.397+j249.73); that is a separate symmetry/patch defect, not touched here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SKce1woVSs18wmKo1ukoqf
This was referenced Nov 20, 2026
Closed
Owner
|
Another regression in sequential! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute_frequency_loop_sequential()sizes the system as N + M, whilenum_eq_symis NP + 2MP. Each surface patch carries two unknowns: NEC-2'sNEQ is N + 2M, as
process_deck_sequential()andcontrol.calready countit. As a result
factor_block_matrix()reports SYMMETRY ERROR, and onec exits1 on every deck with a surface patch. A single
SPis enough.The change is one line in
src/reporting.c: allocate the frequency-loopstorage for
num_segs + 2 * num_patches.Example 4 in your own
examples/DL5SAY collection/EX4.nec, with anFR 0 1 0 0 299.8card added (issue below):SYMMETRY ERROR - NROW: 32 NCOL: 20, exit 1;GXwritten out as eight explicitSPcards it gives 180.728+j217.649, against nec2c's 180.73+j217.65 (measured when we made the fix, on 2.4.1).The deck as published, with
GX 0 110reflecting the patches, stilldisagrees. That's a separate problem, filed as its own issue.
🤖 Generated with Claude Code