Conversation
Silences clang's -Wshift-op-parentheses; the grouping was already what operator precedence produced, so no behavior change.
Builds with g++ and clang++ via autotools and runs t/smoke.sh, which exercises static files, directory listing, content types, CGI GET/POST (including a 300KB body), keep-alive, a 1MB transfer and clean SIGTERM shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GitHub Actions workflow that builds the tree with both g++ and clang++ through the regular autotools flow and then runs a new in-repo smoke test,
t/smoke.sh. The test starts the server against a throwaway docroot and exercises static files, the default page, directory listing, content types, 404s, HEAD, keep-alive, a 1MB transfer, CGI GET/POST including a 300KB request body (run repeatedly to catch the recently fixed CGI race), and clean shutdown on SIGTERM.Also parenthesizes the
_rotlmacro arguments in utils.cxx so the clang leg builds without -Wshift-op-parentheses noise (no behavior change; the grouping matches what precedence already produced).