Repository navigation
Report relay connection errors when no relay is reachable - #46
Merged
Merged
Conversation
The pool's subscription helpers silently skip relays they cannot connect to, and Do only printed connection errors in verbose mode, so with the network down (e.g. Wi-Fi off) commands printed nothing or just "cannot post". Connect to relays up front and fail with the per-relay errors when none connect, and propagate StreamEvents/StreamLive errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the network down (e.g. Wi-Fi off), commands printed nothing (timeline etc.) or just
cannot post.connectRelaysto connect up front inQueryEvents/StreamEvents/StreamLiveand fail with per-relay errors when none connect.timelinenow propagates theStreamEventserror;StreamLivereturns an error.Doprints connection errors to stderr when no relay connected, even without verbose.Partial failures are still reported only in verbose mode.