Repository navigation
Fix duplicated self DMs and publishing to NIP-42 auth relays - #44
Merged
Merged
Conversation
dm timeline -u me listed every message twice: both kind 4 queries are the same when the peer is yourself, and the recipient and sender gift wraps of a NIP-17 DM to yourself unwrap to the same rumor. Skip the redundant query and dedupe rumors by their own ID. Publishing to a relay that answers auth-required always failed, because Do opens its own connection that preAuth never authenticated. Authenticate on that connection and retry once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dm timeline -u meshowed every message twice: the two kind 4 queries are identical when the peer is yourself, and both gift wraps of a NIP-17 DM to yourself unwrap to the same rumor. Skip the redundant query and dedupe rumors by their own ID.auth-required:always failed becauseDoopens a fresh connection thatpreAuthnever authenticated. AddpublishEvent, which authenticates on that connection and retries once, and use it for every publish (except NWC).Verified with
nak serve/nak serve --auth.