Document Elasticsearch v9 support and v7.17 deprecation#8849
Document Elasticsearch v9 support and v7.17 deprecation#8849lieut-data wants to merge 2 commits intomasterfrom
Conversation
Add Elasticsearch v9 as a supported search backend starting from Mattermost v11.7, note that v7.17 is no longer supported, and update version references across setup and requirements documentation.
|
Newest code from mattermost has been published to preview environment for Git SHA d71578b |
|
Newest code from mattermost has been published to preview environment for Git SHA 9ecfc75 |
📝 WalkthroughWalkthroughThis pull request updates Elasticsearch version support documentation across multiple guides. The changes reflect support for Elasticsearch v9 as the current version, deprecate v7.17 support starting with Mattermost v11.7, and update version references throughout the administration and deployment documentation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@source/administration-guide/scale/elasticsearch-setup.rst`:
- Line 46: Update the sentence that advises setting
action.destructive_requires_name to false in elasticsearch.yml to include an
explicit safety note: warn that this setting defaults to true in ES 8/9 and
disabling it permits dangerous wildcard deletes (e.g., DELETE * or DELETE .*)
that can remove system indices used for authentication; state when this
temporary change is required (only for the specific maintenance step described),
require restoring action.destructive_requires_name to true immediately after the
operation, and suggest the safer wildcard exclusion pattern "*,-.*" (exclude
system indices) as an alternative to turning the protection off.
In `@source/deployment-guide/software-hardware-requirements.rst`:
- Line 235: Update the sentence that currently reads "Elasticsearch v8.x and
v9.x are supported, and Elasticsearch v9.x or AWS OpenSearch is recommended" to
qualify v9 support by adding that Elasticsearch v9.x is supported beginning with
Mattermost v11.7 (e.g., "Elasticsearch v8.x is supported; Elasticsearch v9.x is
supported beginning with Mattermost v11.7, and Elasticsearch v9.x or AWS
OpenSearch is recommended"). Keep the existing :doc:`Learn more
</administration-guide/scale/enterprise-search>` link and adjust punctuation as
needed so the sentence remains grammatically correct.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bb6b22b8-9355-48f2-9a3a-15003c1c0e3e
📒 Files selected for processing (3)
source/administration-guide/scale/elasticsearch-setup.rstsource/administration-guide/scale/enterprise-search.rstsource/deployment-guide/software-hardware-requirements.rst
|
Adding the do not merge label so this can be rebased to the 11.7 branch when it's cut |
Summary
Test plan