Repository navigation
feat!: finalize typed CDP semantics and transport performance - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDP values such as
CallArgument(value=None)currently become JavaScriptundefined, command deadlines exclude sending and custom transports, and the default WebSocket path adds avoidable compression and UTF-8 work. This change fixes those semantics and finalizes the generated API while keeping its scope to typed CDP commands, models, events and transport.Changes:
Anyvalues withUNSET, preserve explicit JSON null, and raise structuredCDPDecodeErrorfor missing required fields. Explicitstrict=Falsedecoding remains available.asyncio.timeout()for individual budgets.overflow="error", retain opt-indrop_oldest, and add root/session/global raw event subscriptions.Breaking changes and migration examples are documented in CHANGELOG.md and README.md: optional Any defaults, strict required-field decoding, timeout ownership and None semantics, standalone transport timeout configuration, compression defaults, and bounded-buffer overflow behavior.
The bundled specs are unchanged. Most of the generated diff is attribute/method documentation and direct parameter serialization. The implementation is split into seven commits.
Validation on Windows:
Reproduce: