Repository navigation
fix(labs): link buttons don't underline their label - #6113
Open
MahmoodKhalil57 wants to merge 1 commit into
Open
MahmoodKhalil57 wants to merge 1 commit into
MahmoodKhalil57 wants to merge 1 commit into
Conversation
An md-gb-button with href renders an <a>, and the browser's default link underline stayed on its label. The button now sets text-decoration: none, so a link button looks like any other button.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
md-gb-buttonwithhrefrenders an<a>, and the browser's default link underline stays on its label. The button now setstext-decoration: none, so a link button looks like any other button.The change is one declaration in
labs/gb/components/button/button.scss.