Repository navigation
fix(labs): nav rail menu button doesn't stay pressed while expanded - #6111
Open
MahmoodKhalil57 wants to merge 1 commit into
Open
MahmoodKhalil57 wants to merge 1 commit into
MahmoodKhalil57 wants to merge 1 commit into
Conversation
The built-in menu button of a collapsible md-gb-nav-rail kept the ripple's pressed state layer for as long as the rail was expanded, so it looked held down. The button opens and closes the rail, and its icon already changes between menu and menu_open to show the state. The pressed opacity is now 0 while aria-expanded is true, unless someone is pressing the button.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in menu button of a collapsible
md-gb-nav-railkeeps the ripple's pressed state layer for as long as the rail is expanded, so it looks held down. The button opens and closes the rail, and its icon already changes betweenmenuandmenu_opento show the state. With this change, the pressed opacity is 0 whilearia-expandedistrue, unless someone is pressing the button.The change is one rule in
labs/gb/components/navrail/nav-rail.scss.To reproduce, press and release the menu button of a collapsible rail. The pressed layer stays visible until the rail collapses.