Repository navigation
feat(labs): polish toolbar UX layout - #6067
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
cl/990327342
branch
4 times, most recently
from
September 29, 2026 17:28
bc4039c to
71848f9
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
cl/990327342
branch
3 times, most recently
from
September 29, 2026 17:56
54defb8 to
a903ef8
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
cl/990327342
branch
8 times, most recently
from
September 29, 2026 21:44
c6cfa7c to
bf3d87c
Compare
copybara-service
Bot
force-pushed
the
cl/990327342
branch
from
November 4, 2026 15:31
bf3d87c to
9c58e95
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
cl/990327342
branch
from
November 4, 2026 16:02
9c58e95 to
3248075
Compare
This change implements UX evaluation refinements for the labs toolbar: - Slot spacing: floating toolbars keep a 4px gap between slots and 8px inline padding; docked toolbars never shrink below the 4px gap. Tests assert the rendered gap and padding. - Fix button shapes: enforce circular shape (50%) for icon buttons and pill shape (9999px) for labeled buttons across rest, active, and selected states. - Ensure 48px minimum touch targets on all interactive elements. - Fix hideLabels shape transition: suppress cubic-bezier spring overshoot so buttons transition smoothly between pill and circle without becoming square. - Accessible label derivation: automatically derive ARIA label from text nodes when hideLabels is active, preserving consumer labels. - Individually disabled buttons: scope the toolbar's color overrides to enabled buttons (`:not([disabled], [soft-disabled])`) so a disabled `md-gb-button` / `md-gb-icon-button` inside the toolbar shows the button's own disabled content color (on-surface 38%) with no container (selected or not) and no state layer. CSS only; no toolbar-level disabled propagation. - Update demo playground: update trailing slot to a labeled button with more_vert icon, add per-button disable knobs, and add standard and vibrant toolbars with disabled buttons to Expressive Variants. - Add comprehensive unit test suite in toolbar_test.ts, including spacing and disabled-button tests. PiperOrigin-RevId: 990327342
copybara-service
Bot
force-pushed
the
cl/990327342
branch
from
November 4, 2026 16:11
3248075 to
0d34681
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(labs): polish toolbar UX layout
This change implements UX evaluation refinements for the labs toolbar:
:not([disabled], [soft-disabled])) so a disabledmd-gb-button/md-gb-icon-buttoninside the toolbar shows the button's own disabled content color (on-surface 38%) with no container (selected or not) and no state layer. CSS only; no toolbar-level disabled propagation.