Conversation
vkareh
left a comment
vkareh
left a comment
There was a problem hiding this comment.
This is fantastic work! It doesn't yet work for me entirely for some reason, but it's looking good so far.
| zoom = 1.0; | ||
| break; | ||
|
|
||
| case GDK_KEY_Escape: |
There was a problem hiding this comment.
Can we also make the Enter key apply the crop?
| GtkAction *action_undo, *action_save; | ||
|
|
||
| eom_image_crop (image, x, y, width, height); | ||
| eom_image_modified (image); |
There was a problem hiding this comment.
I don't think this is working for me - the image is not marked as modified, so even if I click Save, the image just goes back to the original...
| priv->image = cropped; | ||
| priv->width = width; | ||
| priv->height = height; | ||
| priv->modified = TRUE; |
There was a problem hiding this comment.
Here you should call eom_image_update_exif_data (same as eom_image_real_transform)
|
|
||
| void (* zoom_changed) (EomScrollView *view, double zoom); | ||
| void (* zoom_changed) (EomScrollView *view, double zoom); | ||
| void (* crop_requested) (EomScrollView *view, gint x, gint y, gint width, gint height); |
There was a problem hiding this comment.
And it's not mandatory, especially as this is not actually used in the class implementation
| priv->has_crop_rect = FALSE; | ||
| priv->crop_drawing = FALSE; | ||
| priv->crop_active_handle = CROP_HANDLE_NONE; | ||
| priv->crop_moving = FALSE; |
There was a problem hiding this comment.
These are all the same in both condition branches, move them out
you have to click inside the drawn rectangle to crop |
Yes, that worked, and it crops it, but I cannot save the image. If I try to save it, I get a banner that says The other issue is that the cropping rectangle only shows up when I release the mouse, so I don't actually see the rectangle until then. |
Ok, that is strange. I do not get any of those issues. I will look into it. |
3 participants
Fix #59