Repository navigation
Fix Offset Overflow during stale_files call - #64
Merged
Merged
Conversation
wyatt-herkamp
marked this pull request as ready for review
October 5, 2026 14:58
xudong963
approved these changes
Oct 8, 2026
zhuqi-lucas
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row metadata scans emitted one row per source file. Since every file in a partition shares the same partition values, each join on those values paired files instead of partitions, multiplying rows by the file count once per join. Views joining tables with many files per partition (e.g. hash-binned files) could produce enough
__metalist data in a single batch to overflow Arrow's 32-bit offsets.scan_columns_from_row_metadatanow groups the row metadata by the scan's partition columns and collects the files witharray_agg, so each scan yields one row per partition. Dependency output is unchanged.Adds
test_binned_self_join_does_not_multiply_files: a 3-way self-join over a partition with 4 files went from 64 rows to 1.