Repository navigation
Conversation
Implemented for GroupValuesColumn and GroupValuesPrimitive; other implementations report supports_find() == false.
Implement find for GroupValuesBytes, GroupValuesBytesView, GroupValuesBoolean and GroupValuesRows, with lookup-only find on ArrowBytesMap and ArrowBytesViewMap. Remove supports_find.
Streaming mode stores one map entry per group even when hashes collide, so find must check equality inside the probe rather than stopping at the first entry with a matching hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a required
GroupValues::find: for each input row, the stored group id orNone, without inserting and without changing stored values or ids.fireflow's rolling aggregation will keep groups in several generations and needs to check older ones without growing them.
internlookup without the insert path.ArrowBytesMapandArrowBytesViewMapget a lookup-onlyfindwith the same null, hash and equality handling asinsert_if_new.new_group_valuespicks the implementation, so a customGroupValuescan't be plugged intoAggregateExec; the break only affects direct implementors.Relates to apache#24603.
Tests
Int32,Utf8,LargeUtf8,Binary,Utf8View,BinaryView,Booleanwith null,(Int64, Utf8)→ column,(List<Int32>, Int32)→ rows):findmatchesintern, missing rows areNone, andlen()is unchanged.cargo test -p datafusion-physical-plan --lib group_values(84 passed), also with--features force_hash_collisions; clippy clean.