Apply per-instance remoteReferences in environment preview - #256
Merged
Merged
Conversation
The preview spec documents a remoteReferences list under each instance, but the CLI dropped the key silently and never set anything. Wire it to SetRemoteReference after the fork and reject unknown config keys so a misspelled or unsupported key fails instead of converging the wrong env. Closes #255 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chrisghill
approved these changes
Sep 12, 2026
ChristensenJoe
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
mass environment previewignored theremoteReferenceslist documented under each instance in the preview spec. The config parsed without error, the environment forked, and no remote references were set.Changes
InstanceOverridegainsremoteReferences(resourceId,field). After params, version, and secrets are applied to a forked instance, each entry callsInstances.SetRemoteReference. A failure aborts before the deploy.UnmarshalStrict, so unknown keys at any level fail with an error naming the key.resourceIdandfield; validation runs before the fork.remoteReferencesblock.Tests
Parsing of UUID and
<instance>.<field>forms, happy path asserting each set call, unknown-key rejection at top, instance, and entry level, required-field validation, and error propagation with no deploy.🤖 Generated with Claude Code