Add condition to refreshVisibleSearch in NotesEditor refs #942 - #943
Open
meusistemabr wants to merge 1 commit into
Open
meusistemabr wants to merge 1 commit into
meusistemabr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Description
Fixes an annoying bug where CodeMirror 6 loses focus completely a few seconds after the user stops typing inside a note.
Cause
The
refreshVisibleSearch(false)orcontent.valuemutation called asynchronously inside CodeMirror'supdateListenertriggers a reactive update/re-mount of the view elements, ripping the active selection and focus away fromdocument.activeElementwhile the user is inside the editor.Solution
Added an
update.view.hasFocusvalidation to prevent the update listener from executing destructive reactive side effects while the editor view is actively focused by the user.