Skip to content

feat: Support collection group#181

Merged
maruware merged 1 commit into
mainfrom
feat/collection-group
May 27, 2026
Merged

feat: Support collection group#181
maruware merged 1 commit into
mainfrom
feat/collection-group

Conversation

@maruware
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for Firestore collection group operations across parsing, execution, tab-completion, tests, and documentation, enabling queries/counts that target all collections with a given collection ID across the DB hierarchy.

Changes:

  • Introduces a COLLECTION_GROUP keyword/token and parsing support for QUERY and COUNT.
  • Extends QueryOperation / CountOperation to track collection-group mode and updates the executor to run collection-group queries.
  • Updates docs and adds parser/executor/completer test cases for collection-group usage.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
token.go Adds COLLECTION_GROUP token/keyword mapping.
parser.go Parses QUERY/COLLECTION_GROUP <id> and COUNT/COLLECTION_GROUP <id>; validates group name.
parser_test.go Adds parse tests for collection-group query/count.
operation.go Adds collectionGroup flag + constructors/accessors for query/count operations.
executor.go Executes collection-group query/count paths in Firestore.
executor_test.go Adds executor tests for collection-group query/count behavior.
docs/operations.md Documents collection-group syntax, examples, and constraints.
completer.go Adds COLLECTION_GROUP completion support for query/count.
completer_test.go Adds completion tests around COLLECTION_GROUP keyword flows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread executor.go
Comment thread parser.go Outdated
Comment thread parser.go Outdated
Comment thread completer.go Outdated
Comment thread completer.go Outdated
Comment thread token.go Outdated
@maruware maruware force-pushed the feat/collection-group branch from 8e51388 to d4b1cbd Compare May 27, 2026 17:58
@maruware maruware merged commit 8ef4018 into main May 27, 2026
1 check passed
@maruware maruware deleted the feat/collection-group branch May 27, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants