Repository navigation
feat(desktop): support custom user data directories - #756
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markra currently ignores
--user-data-dir, so a portable executable still uses the system profile. This adds a startup option for keeping settings and persistent app data in a directory on a USB drive or another user-selected location.--user-data-dir=<path>and--user-data-dir <path>; resolve relative paths against the launch working directory, create missing directories, and reject invalid or unwritable storage.Closes #755.
Validation
cargo test --lib --quiet: 313 tests passed.cargo fmt --all --check: passed.cargo build: passed on macOS.pnpm --filter @markra/desktop test: 178 tests passed.pnpm --filter @markra/desktop build: passed, including vendor chunk verification.pnpm --filter @markra/desktop typecheck:test: passed.Platform and migration notes
The existing system profile remains the default when the option is omitted. New directories start with independent settings; existing data is not moved automatically, and external document paths are not rewritten. Quit Markra completely before switching directories.
Windows/Linux webviews use the selected directory. macOS custom profiles use ephemeral WKWebView storage because arbitrary cache directories are unsupported; durable Markra data still uses native profile paths.
Windows/Linux native runtime QA has not been performed. The local Windows cross-compile attempt stopped before compilation because the offline cache lacked
clipboard-win v5.4.1; the PR CI includes Windows test compilation and Linux/macOS tests.