[sumanthravipati]

No description provided.

[Copilot]

🟡 Changes recommended

CloudFormation validation and EBS device-mapping issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates MarkLogic AWS CloudFormation templates and packaging for version 12.1.0, adding Amazon Linux 2023 Graviton support and newer EBS mappings.

Changes:

• Adds Graviton parameters, AMI mappings, and documentation.
• Extends EC2 device-family mappings.
• Updates versions, release metadata, packaging, and SBOM data.

File summaries

File	Summary
templates/ml-vpc.template	Updates nested template version.
templates/ml-nodemanager.template	Updates nested template version.
templates/ml-managedeni.template	Updates nested template version.
README.md	Documents Graviton support.
mlcmd/conf/ebs-devices.xml	Adds newer family mappings; interpolation and fallback matching issues remain.
mlcluster.template	Adds 12.1.0 and Graviton configuration; contains invalid condition IDs and separator values.
mlcluster-vpc.template	Adds 12.1.0 and Graviton configuration; contains invalid condition IDs and separator values.
marklogic-mlcmd.spec	Updates RPM version.
MarkLogic_AWSCFT-12.1.0.spdx.json	Adds 12.1.0 SBOM metadata.
Makefile	Updates build version.

Review details

Suppressed comments (3)

mlcluster-vpc.template:162

• These separator strings are actual AllowedValues, not display-only headings. A user can select one, CloudFormation will accept it, and the launch template will then pass an invalid EC2 instance type to the launch API. Remove both separator entries from this parameter's AllowedValues (or otherwise enforce real instance types only).

      - ---- Pay-As-You-Go and Bring-Your-Own-License ----

mlcluster.template:162

• These separator strings are actual AllowedValues, not display-only headings. A user can select one, CloudFormation will accept it, and the launch template will then pass an invalid EC2 instance type to the launch API. Remove both separator entries from this parameter's AllowedValues (or otherwise enforce real instance types only).

      - ---- Pay-As-You-Go and Bring-Your-Own-License ----

mlcmd/conf/ebs-devices.xml:70

• When the new EnableInstanceFamily parameter has its default empty value, this interpolation makes the regex end in |)\..*, so matches() accepts any instance type containing a dot. That causes legacy types still offered by the templates, such as t2.* and m4.*, to select /dev/nvme1n1 instead of the existing /dev/xvd* fallback, breaking volume discovery and startup. Make the optional alternative nonmatching when empty (or generate it only when the parameter is nonempty).

            <instance family="(c5|c5a|c5ad|c5d|c5n|c6a|c6i|c6id|c6g|c6gd|c6gn|cc2|c7i|c7i-flex|c7a|c7g|c7gd|c7gn|c8g|c8gd|c8gn|c8gb|c8a|c8i|c8i-flex|m5|m5a|m5ad|m5d|m5zn|m5n|m5dn|m6a|m6i|m6id|m6g|m6gd|m7i|m7i-flex|m7a|m7g|m7gd|m8g|m8gd|m8gn|m8gb|m8a|m8i|m8i-flex|r5|r5a|r5ad|r5d|r5b|r5dn|r5n|r6a|r6i|r6id|r6g|r6gd|r7i|r7iz|r7a|r7g|r7gd|r8a|r8i|r8i-flex|r8g|r8gd|r8gn|r8gb|t3|t3a|t4g|z1d|i3en|d3|d3en|i4i|i7ie|x2idn|x2iedn|x2iezn|u-3tb1|u-6tb1|u-9tb1|u-12tb1|u-18tb1|u-24tb1|g4ad|g4dn|g5|x8g|i8g|i8ge|hpc7g|dl1|inf1|trn1|vt1|${MARKLOGIC_ENABLE_INSTANCE_FAMILY})\..*" device="/dev/nvme1n1"/>

• Files reviewed: 10/29 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.