Repository navigation
The pin moves to the interpreter upstream publishes now - #28
Merged
Merged
Conversation
Upstream rebuilt php-8.4.27 for all four platforms without changing the version, so the file the name points at holds different bytes than it held when the pin was taken — three days after the last move (91089e8), and the one before it. The four pins are the digests upstream publishes now, and every one of them was checked against the download itself and not only against the .sha256 file beside it. The comment above the pin says the pin moves with the PHP version, because the version is part of the file's name. It does not: the version is in the name and the build is not identified by it. The pin is on a build, and it has to be moved by hand when upstream rebuilds one. What it buys is that the change is noticed rather than absorbed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream rebuilt
php-8.4.27for all four platforms without changing the version, so the file the name points at holds different bytes than it held when the pin was taken.The pin is doing its job. The build stops at the pin and says which bytes it found and which it expected, rather than absorbing the change — but the release could not have gone out.
The four pins are the digests upstream publishes now. Every one of them was checked against the download itself and not only against the
.sha256file beside it.This is the third move in four days:
91089e8was the last one, and#26the one before that. The comment above the pin already says the pin is on a build rather than on a version and has to be moved by hand when upstream rebuilds one — nothing in it needed changing.