Repository navigation
The pin moves to the interpreter upstream publishes now - #26
Merged
Merged
Conversation
Upstream rebuilt php-8.4.27 for all four platforms without changing the version, so the file the name points at holds different bytes than it held when the pin was taken. The build stopped at the pin and said which bytes it found and which it expected — the pin doing its job — but the release could not have gone out. The four pins are the digests upstream publishes now, cross-checked against the .sha256 files beside the downloads, and one of them against the download itself.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream rebuilt
php-8.4.27for all four platforms without changing the version, so the file the name points at holds different bytes than it held when the pin was taken.The untagged pipeline run found it. Three of the four prebuilt platforms stopped at the pin —
macos-arm64,macos-x86_64,linux-x86_64andlinux-aarch64all failing at Fetch the published interpreter — and the Windows build, which compiles its own interpreter, was unaffected.The pin is doing its job: the build stops and says which bytes it found and which it expected, rather than absorbing the change. But the release could not have gone out.
The four pins are the digests upstream publishes now, cross-checked against the
.sha256files beside the downloads, and one of them (linux-x86_64) against the download itself.The comment above the pin is already right
It says the pin is on a build rather than on a version, and that it has to be moved by hand when upstream rebuilds one. That is what happened, three days after the last move (
91089e8). Nothing in the comment needed changing.What this has to land before
The release. The tag waits for this to merge, and then the pipeline runs without a tag once more, because a release waits for every binary.