Repository navigation
The 0.1.2 release - #25
Merged
Merged
Conversation
The changelog gains the heading the release job reads, the version constant moves, and the download URL names the version that is published.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The changelog gains the heading the release job reads, the version constant moves, and the download URL names the version that is published.
The three things a release of this one needs
src/Console/Application.phpnow says0.1.2, andmdoffice --versionanswers it.mdoffice-0.1.2-macos-arm64. The assets are named after the version, so a URL naming a version that was never published is a 404 forever. The documentation site's installation page has the other four, and it is the last thing to change.What is in it
Added —
mdoffice theme init <deck.pptx>writes a theme from a deck.Changed — a deck on standard output is the renderer's own bytes rather than a temporary file the command made and read back;
theme initreads the theme it wrote back the way the library reads one.What is left, and it is the part that costs time
Run the pipeline without a tag first. The release waits for every binary — five of them, published together — so one platform failing publishes nothing on any platform:
That is the step that finds a platform that does not build, and it is the reason the v0.1.0 release was never published.
Then the tag, which is a person's to make:
And the checks afterwards, because the job cannot check what it does not know:
This release needs the libraries' v0.3.0 first. The archive holds the newest release in the series the manifest names —
^0.3for both — and not a branch, because a branch satisfies no constraint. Somarkdown-office/markdown-wordv0.3.0 andmarkdown-office/markdown-presentationv0.3.0 have to be published before this tag, or the archive build cannot resolve them.The Homebrew formula and the
wingetmanifest are written by that repository's workflow from the release, and each opens a pull request for a person to merge.