[fabeat]

The deck on standard output is the renderer's own bytes, and theme init reads a theme back the way the library reads one.

The deck to standard output

mdoffice slides to-pptx -o - wrote the deck to a temporary file, read it back and removed it. Its own comment said why:

The renderer writes the file rather than returning its bytes, so to standard output means to a temporary file that is read back and removed. A .pptx is a zip archive, and building one in memory would mean carrying PHPWord's writer around a second path for the sake of a pipe.

The renderer returns its bytes now. PresentationRenderer::toString(Deck $deck): string gives the deck as the bytes of a .pptx — it stages to a temporary file of the library's own and reads that back, so the command no longer has to make one. The command's temporary(), its finally and its cleanup all go away with it.

Every other output still goes through render($deck, $path).

theme init — a break the library's change caused

ThemeLoader::load()'s first parameter is now a theme's name rather than its directory. theme init was passing a directory, so against the new libraries it refused every deck with "… is not a theme: it has no theme.yml".

It now passes the directory's own name with a finder rooted at its parent — the shape ThemeResolver uses. The failure messages, and the theme.yml, layouts.yml and template.pptx that are read, are unchanged.

What did not change

No command, no option, no exit code and no message. The two other library call sites — MarkdownToWord::__construct()'s new trailing named parameters, and TemplateFile::__construct()'s — needed no change at all.

The tests

• a deck written to standard output is the same deck written to a file — compared by the ppt/slides/slideN.xml parts, never by the archive bytes, because a zip stores 2-second timestamps and docProps/core.xml carries creation and modification times. The test also asserts there are three parts, so two empty sets would not pass;
• a piped run leaves no file behind in the system temp directory — the whole directory diffed before and after, for a successful run and for a refused one. The library stages its own file there now, so a glob of the command's own prefix would have been blind to it;
• the theme theme init writes is resolved through the library's own ThemeResolver, the way a deck beside it finds one.

The release

This branch needs the two libraries merged and released before it is released, not before it is merged: the archive build resolves them from their GitHub releases, so it cannot succeed until they carry a published tag in the ^0.3 series.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud