Skip to content

The contributor instructions say what the manifest does - #41

Merged
fabeat merged 1 commit into
mainfrom
fix/validate-strict
Oct 30, 2026
Merged

fabeat merged 1 commit into
mainfrom
fix/validate-strict

Conversation

@fabeat

@fabeat fabeat commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

The instructions said:

composer validate is run without --strict on purpose: the manifest pins a commit of PHPPresentation's master branch rather than a tag, and --strict refuses that.

Both halves of that are false now. The manifest requires phpoffice/phppresentation at ~1.2.0 — a range of tags — and composer check runs composer validate --strict, which passes. The fixes this library needs are not in that release, so they come from a patch the library applies to the installed package, and the README says what a project has to allow for the patch to land.

The instructions now say that, and the command in the list carries --strict.

The claim is pinned

tests/Unit/dead-code.php guards the claims that have been wrong before, and it reads CONTRIBUTING.md along with the README and the changelog. Two entries are added:

'the manifest pins a commit of PHPPresentation master' => 'pins a commit of',
'the contributor instructions say validate runs without strict' => '`composer validate` is run **without**',

Both were shown to fire: with the old text restored, the guard fails with two problems; with the new text it passes.

It does not wait for the release. This is a documentation fix, not part of the release, so it stands on its own.

The manifest requires a tag range and `composer validate --strict` passes, so the instruction to leave the flag off and the reason for it were both false. The fixes the library needs come from a patch, and the README says what a project has to allow for it to land.
@sonarqubecloud

Copy link
Copy Markdown

@fabeat
fabeat merged commit aae7a99 into main Oct 30, 2026
8 checks passed
@fabeat
fabeat deleted the fix/validate-strict branch October 30, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant