Repository navigation
The contributor instructions say what the manifest does - #41
Merged
Merged
Conversation
The manifest requires a tag range and `composer validate --strict` passes, so the instruction to leave the flag off and the reason for it were both false. The fixes the library needs come from a patch, and the README says what a project has to allow for it to land.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The instructions said:
Both halves of that are false now. The manifest requires
phpoffice/phppresentationat~1.2.0— a range of tags — andcomposer checkrunscomposer validate --strict, which passes. The fixes this library needs are not in that release, so they come from a patch the library applies to the installed package, and the README says what a project has to allow for the patch to land.The instructions now say that, and the command in the list carries
--strict.The claim is pinned
tests/Unit/dead-code.phpguards the claims that have been wrong before, and it readsCONTRIBUTING.mdalong with the README and the changelog. Two entries are added:Both were shown to fire: with the old text restored, the guard fails with two problems; with the new text it passes.
It does not wait for the release. This is a documentation fix, not part of the release, so it stands on its own.