Repository navigation
The pins move with the 0.3.1 releases - #21
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The site installs the two libraries as path repositories and pins the exact version, so it names a released version twice: once in
requireand once in the path repository'sversionsmap. Both move to 0.3.1, and the lock file with them.The lock file carries more than the two versions, and it is worth saying what. Both libraries carry a patch of their own —
phpoffice/phpwordandphpoffice/phppresentation— and the lock file records the URL and the checksum of each, so the site applies them. That is not incidental: it is what puts the site's documents through the patched PHPWord, and it is why the site needs the pinned versions at all.composer-patchesreads the patches of a dependency out of the lock file, so the patch reaches the site without the site naming it.The transcript on the command-line page moves with it: an installed
mdofficetakes the newest release in the^0.3series, so it answersv0.3.1once the tags are cut.The patch the lock file names moved with them. The PHPPresentation patch carries
four fixes now, and the third and fourth are the ones a review of the chart fix found:
the data points of a series that the area, the line, the radar and the scatter dropped,
and the fill of the series that a doughnut, a pie and a pie in three dimensions
dropped. The patch is a different file with a different checksum, and the lock file
records both — so the lock file moves too.
The site renders its examples with the code checked out beside it, so this is what puts the documents the site shows through the patched PHPWord.