Repository navigation
The pages call the file a templates file, not a chrome file - #17
Merged
Merged
Conversation
The library renamed the key that points at a file of template definitions: `chrome:` is `templates-file:` now, and the file it names is a templates file. The word "chrome" keeps its other meaning — the shapes a template draws — and the pages keep it there. The exceptions follow the library: `ChromeNotFound` and `ChromeTooLarge` are `TemplatesFileNotFound` and `TemplatesFileTooLarge`, and a templates file that holds a slide is now `MalformedTemplatesFile` rather than a case of `MalformedChrome`.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library renamed the frontmatter key that points at a file of template definitions.
chrome:istemplates-file:now, and the file it names is a templates file. The word "chrome" keeps its other meaning in the library — the shapes a template draws — and the pages keep it there.chrome: ./chrome.mdtemplates-file: ./templates.mdException\ChromeNotFoundException\TemplatesFileNotFoundException\ChromeTooLargeException\TemplatesFileTooLargeMalformedChromeMalformedChrome, for a template's body onlyException\MalformedTemplatesFile, for a file that holds a slideThe pages that change:
presentation/directives.md— the frontmatter key table, the sentence about which keys belong to the first slide, and the section that was "The chrome file" and is now "The templates file".presentation/themes.md— the sentence about the path resolving against the deck's own directory.presentation/errors.md— the exception table follows the library's split.presentation/index.md— theMAX_BYTESceiling is "the size of a templates file".src/Reference/Vocabularies.phpnamesTemplatesFile::MAX_BYTESrather thanChromeFile::MAX_BYTES, so the reference check reads the library's class rather than a name it cannot resolve.This pull request cannot be built against
mainof the libraryThe site renders its examples with the library, and the claim tests render decks that use
templates-file:.mainofmarkdown-office/markdown-presentationdoes not have the rename yet, so the build needs the library's branch:That is the case the variable exists for — a page about a feature the library does not have on
mainyet. It should go back tomainonce markdown-office/markdown-presentation#37 is merged.Checks
composer checkpasses locally against the library's branch: the example render in strict mode, the reference check, the README link check, and 50 Pest tests over 135 assertions.