feat: Add ML Kit zoom suggestions to the Barcode Scanner output (Andr… - #4201
Open
xTMNTxRaphaelx wants to merge 1 commit into
Open
xTMNTxRaphaelx wants to merge 1 commit into
xTMNTxRaphaelx wants to merge 1 commit into
Conversation
|
@xTMNTxRaphaelx is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android ML Kit can detect that a QR is visible but too small to decode, and can suggest the zoom level needed to read it (ZoomSuggestionOptions). Previously, this information never reached the app, so we couldn't do the same automatic zoom that Google Lens does.
Verification
On a OnePlus 8 with a dense desktop QR at arm's length:
Before: QR detected, but never decoded.
After: ML Kit suggested 1.9× once → app applied the zoom → QR decoded.
One implementation detail: the callback currently returns true to ML Kit regardless of whether JS actually applies the zoom, because the JS callback is asynchronous. If maintainers prefer, this could instead allow ML Kit to re-suggest when the zoom isn't applied.