Skip to content

fix: Don't capture CameraImpl's scope in the PreviewView hybridRef callback #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rayabelcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Don't capture CameraImpl's scope in the PreviewView hybridRef callback #4197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions packages/react-native-vision-camera/src/views/Camera.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import React, { type Ref, useImperativeHandle, useMemo, useRef } from 'react'
import React, {
type Ref,
type RefObject,
useImperativeHandle,
useMemo,
useRef,
} from 'react'
import type { ViewProps } from 'react-native'
import { callback } from 'react-native-nitro-modules'
import type { SharedValue } from 'react-native-reanimated'
Expand Down Expand Up @@ -109,6 +115,15 @@ export interface CameraViewProps
ref?: Ref<CameraRef>
}

// Module-level so the callback handed to native captures only the ref object.
// Native holds this callback for as long as the native view lives; created inside
// CameraImpl it would keep CameraImpl's whole scope alive, including its props.
function createHybridRefSetter(ref: RefObject<PreviewView | null>) {
return callback((r: PreviewView) => {
ref.current = r
})
}

function CameraImpl({
implementationMode,
resizeMode,
Expand All @@ -131,13 +146,7 @@ function CameraImpl({

// 4. Create `ref` for `PreviewView`
const previewViewRef = useRef<PreviewView>(null)
const setHybridRef = useMemo(
() =>
callback((r: PreviewView) => {
previewViewRef.current = r
}),
[],
)
const setHybridRef = useMemo(() => createHybridRefSetter(previewViewRef), [])

// 5. Create a ref that exposes some funcs on the Controller and the PreviewView.
useImperativeHandle(
Expand Down